Revise WSI setup.

Revise WSI setup.

- Set up present queue creation correctly.
- Move WSI functions to VulkanTestContext.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1899213002

Committed: https://skia.googlesource.com/skia/+/b0d4352ca610654f98c3c4ebc67ed9ad9c8c8493

[jvanverth1, 2016-04-19 14:34:03]

Description was changed from

==========
Revise WSI setup.

- Set up present queue creation correctly.
- Move WSI functions to VulkanTestContext.
==========

to

==========
Revise WSI setup.

- Set up present queue creation correctly.
- Move WSI functions to VulkanTestContext.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[jvanverth1, 2016-04-19 14:40:18]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, djsollen@google.com, egdaniel@google.com

[jvanverth1, 2016-04-19 14:40:18]

jvanverth@google.com changed required reviewers:
+ egdaniel@google.com

[jvanverth1, 2016-04-20 17:52:42]

On 2016/04/19 14:40:18, jvanverth1 wrote:

PTAL

[egdaniel, 2016-04-20 18:26:55]

https://codereview.chromium.org/1899213002/diff/1/src/gpu/vk/GrVkBackendConte...
File src/gpu/vk/GrVkBackendContext.cpp (right):

https://codereview.chromium.org/1899213002/diff/1/src/gpu/vk/GrVkBackendConte...
src/gpu/vk/GrVkBackendContext.cpp:148: if (graphicsQueueIndex == queueCount &&
queueProps[i].queueFlags & VK_QUEUE_GRAPHICS_BIT) {
why is this needed in the if? Seems like the only time we update gQueueIdx we
break out of for loop anyways.

https://codereview.chromium.org/1899213002/diff/1/src/gpu/vk/GrVkBackendConte...
src/gpu/vk/GrVkBackendContext.cpp:159: if (presentQueueIndex == queueCount &&
canPresent(inst, physDev, i)) {
Assuming the assert above is true, presentQueueIndex will never equal queueCount
since we set it to graphicsQueueIndex and then break the only other time we
change it.

[jvanverth1, 2016-04-20 18:32:25]

https://codereview.chromium.org/1899213002/diff/1/src/gpu/vk/GrVkBackendConte...
File src/gpu/vk/GrVkBackendContext.cpp (right):

https://codereview.chromium.org/1899213002/diff/1/src/gpu/vk/GrVkBackendConte...
src/gpu/vk/GrVkBackendContext.cpp:148: if (graphicsQueueIndex == queueCount &&
queueProps[i].queueFlags & VK_QUEUE_GRAPHICS_BIT) {
On 2016/04/20 18:26:54, egdaniel wrote:
> why is this needed in the if? Seems like the only time we update gQueueIdx we

Good catch. This and the if below are from when both were in the same loop.

[jvanverth1, 2016-04-21 15:57:26]

Updated to ToT and comments addressed.

[djsollen, 2016-04-21 16:05:47]

android lgtm

[egdaniel, 2016-04-21 18:28:29]

lgtm

[jvanverth1, 2016-04-21 18:31:19]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-04-21 18:31:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899213002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899213002/20001

[commit-bot: I haz the power, 2016-04-21 18:46:25]

Description was changed from

==========
Revise WSI setup.

- Set up present queue creation correctly.
- Move WSI functions to VulkanTestContext.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Revise WSI setup.

- Set up present queue creation correctly.
- Move WSI functions to VulkanTestContext.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/b0d4352ca610654f98c3c4ebc67ed9ad9c8c8493
==========

[commit-bot: I haz the power, 2016-04-21 18:46:26]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b0d4352ca610654f98c3c4ebc67ed9ad9c8c8493