Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
Lei Zhang
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, grt+watch_chromium.org, kalyank, markusheintz_, native-client-reviews_googlegroups.com, Robert Sesek, sadrul, tfarina, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //chrome from scoped_ptr to std::unique_ptr BUG=554298 NOPRESUBMIT=true Committed: https://crrev.com/c0e39d57d0c16684ff7c99632fba9a49d4d2431e Cr-Commit-Position: refs/heads/master@{#388145}

Patch Set 1 #

Total comments: 14

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -254 lines) Patch
M chrome/app/android/chrome_main_delegate_android.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/app/chrome_main_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/chrome_watcher_command_line_win.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/app/chrome_watcher_command_line_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/chrome_watcher_command_line_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/main_dll_loader_win.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/app/mash/mash_runner.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/app/mash/mash_runner.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/app_shim/chrome_main_app_mode_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/cookies_tree_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_channel_id_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browsing_data/mock_browsing_data_cookie_helper.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/dom_distiller/lazy_dom_distiller_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/locale_tests_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/test/nacl_gdb_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/process_singleton_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ssl/bad_clock_blocking_page.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/certificate_reporting_test_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cdd_conversion_win.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cdd_conversion_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_auth.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/connector_settings.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/connector_settings_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/service/cloud_print/print_system_win.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/printer_job_queue_handler.h View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/printer_job_queue_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/net/service_url_request_context_getter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/service_ipc_server.h View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/service/service_ipc_server_unittest.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/service/service_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_process.h View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/service/service_process.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/service/service_process_prefs.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/service/service_process_prefs.cc View 5 chunks +8 lines, -9 lines 0 comments Download
M chrome/service/service_process_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/service_utility_process_host.h View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/third_party/mozilla_security_manager/nsNSSCertHelper.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/tools/mac_helpers/infoplist_strings_util.mm View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/tools/service_discovery_sniffer/service_discovery_sniffer.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/tools/service_discovery_sniffer/service_discovery_sniffer.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/cloud_print/bitmap_image.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/utility/cloud_print/pwg_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/cloud_print/pwg_encoder_unittest.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/image_decoder_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/utility/image_writer/disk_unmounter_mac.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/utility/image_writer/disk_unmounter_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/image_writer/image_writer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/image_writer/image_writer.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/utility/image_writer/image_writer_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/image_writer/image_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/image_writer/image_writer_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/edge_database_reader_unittest_win.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M chrome/utility/importer/edge_database_reader_win.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/edge_database_reader_win.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/utility/importer/edge_importer_win.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/external_process_importer_bridge.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/firefox_importer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/importer/nss_decryptor.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/media_metadata_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/pmp_column_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/profile_import_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/utility/safe_browsing/mac/crdmg.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/safe_browsing/mac/dmg_analyzer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/utility/safe_browsing/mac/dmg_iterator.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/utility/safe_browsing/mac/dmg_iterator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/safe_browsing/mac/hfs.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/utility/safe_browsing/mac/hfs.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/utility/safe_browsing/mac/hfs_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/utility/safe_browsing/mac/read_stream_unittest.cc View 8 chunks +18 lines, -13 lines 0 comments Download
M chrome/utility/safe_browsing/mac/udif.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/utility/safe_browsing/mac/udif.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/utility/safe_browsing/mac/udif_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/safe_json_parser_handler.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/utility/shell_handler_win.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
This should wrap up //chrome. I'll have to dcommit once the trybots are happy, since ...
4 years, 8 months ago (2016-04-19 01:19:44 UTC) #2
Lei Zhang
https://codereview.chromium.org/1899083002/diff/1/chrome/installer/mini_installer/decompress.cc File chrome/installer/mini_installer/decompress.cc (right): https://codereview.chromium.org/1899083002/diff/1/chrome/installer/mini_installer/decompress.cc#newcode88 chrome/installer/mini_installer/decompress.cc:88: std::unique_ptr<wchar_t> path(Utf8ToWide(pszFile)); Weren't we going to leave this alone? ...
4 years, 8 months ago (2016-04-19 01:35:43 UTC) #3
dcheng
https://codereview.chromium.org/1899083002/diff/1/chrome/installer/mini_installer/decompress.cc File chrome/installer/mini_installer/decompress.cc (right): https://codereview.chromium.org/1899083002/diff/1/chrome/installer/mini_installer/decompress.cc#newcode88 chrome/installer/mini_installer/decompress.cc:88: std::unique_ptr<wchar_t> path(Utf8ToWide(pszFile)); On 2016/04/19 at 01:35:42, Lei Zhang wrote: ...
4 years, 8 months ago (2016-04-19 03:51:34 UTC) #4
Lei Zhang
lgtm
4 years, 8 months ago (2016-04-19 04:12:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899083002/20001
4 years, 8 months ago (2016-04-19 06:13:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 06:15:27 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 06:16:38 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c0e39d57d0c16684ff7c99632fba9a49d4d2431e
Cr-Commit-Position: refs/heads/master@{#388145}

Powered by Google App Engine
This is Rietveld 408576698