Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Side by Side Diff: chrome/service/cloud_print/connector_settings_unittest.cc

Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/service/cloud_print/connector_settings.h" 5 #include "chrome/service/cloud_print/connector_settings.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 }; 77 };
78 78
79 TEST_F(ConnectorSettingsTest, InitFromEmpty) { 79 TEST_F(ConnectorSettingsTest, InitFromEmpty) {
80 const char* const kEmptyJSons[] = { 80 const char* const kEmptyJSons[] = {
81 NULL, 81 NULL,
82 "{}", 82 "{}",
83 "{'foo': []}", 83 "{'foo': []}",
84 "{'foo',,}", 84 "{'foo',,}",
85 }; 85 };
86 for (size_t i = 0; i < arraysize(kEmptyJSons); ++i) { 86 for (size_t i = 0; i < arraysize(kEmptyJSons); ++i) {
87 scoped_ptr<ServiceProcessPrefs> prefs(CreateTestFile(kEmptyJSons[i])); 87 std::unique_ptr<ServiceProcessPrefs> prefs(CreateTestFile(kEmptyJSons[i]));
88 ConnectorSettings settings; 88 ConnectorSettings settings;
89 settings.InitFrom(prefs.get()); 89 settings.InitFrom(prefs.get());
90 90
91 EXPECT_EQ("https://www.google.com/cloudprint", 91 EXPECT_EQ("https://www.google.com/cloudprint",
92 settings.server_url().spec()); 92 settings.server_url().spec());
93 EXPECT_FALSE(settings.proxy_id().empty()); 93 EXPECT_FALSE(settings.proxy_id().empty());
94 EXPECT_FALSE(settings.delete_on_enum_fail()); 94 EXPECT_FALSE(settings.delete_on_enum_fail());
95 EXPECT_EQ(NULL, settings.print_system_settings()); 95 EXPECT_EQ(NULL, settings.print_system_settings());
96 EXPECT_TRUE(settings.ShouldConnect("prn1")); 96 EXPECT_TRUE(settings.ShouldConnect("prn1"));
97 EXPECT_FALSE(settings.xmpp_ping_enabled()); 97 EXPECT_FALSE(settings.xmpp_ping_enabled());
98 } 98 }
99 } 99 }
100 100
101 TEST_F(ConnectorSettingsTest, InitFromFile) { 101 TEST_F(ConnectorSettingsTest, InitFromFile) {
102 scoped_ptr<ServiceProcessPrefs> prefs(CreateTestFile(kServiceStateContent)); 102 std::unique_ptr<ServiceProcessPrefs> prefs(
103 CreateTestFile(kServiceStateContent));
103 ConnectorSettings settings; 104 ConnectorSettings settings;
104 settings.InitFrom(prefs.get()); 105 settings.InitFrom(prefs.get());
105 EXPECT_EQ("https://www.google.com/cloudprint", settings.server_url().spec()); 106 EXPECT_EQ("https://www.google.com/cloudprint", settings.server_url().spec());
106 EXPECT_EQ("PROXY", settings.proxy_id()); 107 EXPECT_EQ("PROXY", settings.proxy_id());
107 EXPECT_FALSE(settings.proxy_id().empty()); 108 EXPECT_FALSE(settings.proxy_id().empty());
108 EXPECT_TRUE(settings.delete_on_enum_fail()); 109 EXPECT_TRUE(settings.delete_on_enum_fail());
109 EXPECT_TRUE(settings.print_system_settings()); 110 EXPECT_TRUE(settings.print_system_settings());
110 EXPECT_TRUE(settings.xmpp_ping_enabled()); 111 EXPECT_TRUE(settings.xmpp_ping_enabled());
111 EXPECT_EQ(settings.xmpp_ping_timeout_sec(), 256); 112 EXPECT_EQ(settings.xmpp_ping_timeout_sec(), 256);
112 EXPECT_FALSE(settings.ShouldConnect("prn0")); 113 EXPECT_FALSE(settings.ShouldConnect("prn0"));
113 EXPECT_FALSE(settings.ShouldConnect("prn1")); 114 EXPECT_FALSE(settings.ShouldConnect("prn1"));
114 EXPECT_TRUE(settings.ShouldConnect("prn3")); 115 EXPECT_TRUE(settings.ShouldConnect("prn3"));
115 } 116 }
116 117
117 TEST_F(ConnectorSettingsTest, CopyFrom) { 118 TEST_F(ConnectorSettingsTest, CopyFrom) {
118 scoped_ptr<ServiceProcessPrefs> prefs(CreateTestFile(kServiceStateContent)); 119 std::unique_ptr<ServiceProcessPrefs> prefs(
120 CreateTestFile(kServiceStateContent));
119 ConnectorSettings settings1; 121 ConnectorSettings settings1;
120 settings1.InitFrom(prefs.get()); 122 settings1.InitFrom(prefs.get());
121 123
122 ConnectorSettings settings2; 124 ConnectorSettings settings2;
123 settings2.CopyFrom(settings1); 125 settings2.CopyFrom(settings1);
124 126
125 EXPECT_EQ(settings1.server_url(), settings2.server_url()); 127 EXPECT_EQ(settings1.server_url(), settings2.server_url());
126 EXPECT_EQ(settings1.proxy_id(), settings2.proxy_id()); 128 EXPECT_EQ(settings1.proxy_id(), settings2.proxy_id());
127 EXPECT_EQ(settings1.delete_on_enum_fail(), settings2.delete_on_enum_fail()); 129 EXPECT_EQ(settings1.delete_on_enum_fail(), settings2.delete_on_enum_fail());
128 EXPECT_EQ(settings1.print_system_settings()->size(), 130 EXPECT_EQ(settings1.print_system_settings()->size(),
129 settings2.print_system_settings()->size()); 131 settings2.print_system_settings()->size());
130 EXPECT_EQ(settings1.xmpp_ping_enabled(), settings2.xmpp_ping_enabled()); 132 EXPECT_EQ(settings1.xmpp_ping_enabled(), settings2.xmpp_ping_enabled());
131 EXPECT_EQ(settings1.xmpp_ping_timeout_sec(), 133 EXPECT_EQ(settings1.xmpp_ping_timeout_sec(),
132 settings2.xmpp_ping_timeout_sec()); 134 settings2.xmpp_ping_timeout_sec());
133 EXPECT_FALSE(settings2.ShouldConnect("prn0")); 135 EXPECT_FALSE(settings2.ShouldConnect("prn0"));
134 EXPECT_FALSE(settings2.ShouldConnect("prn1")); 136 EXPECT_FALSE(settings2.ShouldConnect("prn1"));
135 EXPECT_TRUE(settings2.ShouldConnect("prn3")); 137 EXPECT_TRUE(settings2.ShouldConnect("prn3"));
136 } 138 }
137 139
138 TEST_F(ConnectorSettingsTest, SettersTest) { 140 TEST_F(ConnectorSettingsTest, SettersTest) {
139 scoped_ptr<ServiceProcessPrefs> prefs(CreateTestFile("{}")); 141 std::unique_ptr<ServiceProcessPrefs> prefs(CreateTestFile("{}"));
140 ConnectorSettings settings; 142 ConnectorSettings settings;
141 settings.InitFrom(prefs.get()); 143 settings.InitFrom(prefs.get());
142 EXPECT_FALSE(settings.xmpp_ping_enabled()); 144 EXPECT_FALSE(settings.xmpp_ping_enabled());
143 145
144 // Set and check valid settings. 146 // Set and check valid settings.
145 settings.set_xmpp_ping_enabled(true); 147 settings.set_xmpp_ping_enabled(true);
146 settings.SetXmppPingTimeoutSec(256); 148 settings.SetXmppPingTimeoutSec(256);
147 EXPECT_TRUE(settings.xmpp_ping_enabled()); 149 EXPECT_TRUE(settings.xmpp_ping_enabled());
148 EXPECT_EQ(settings.xmpp_ping_timeout_sec(), 256); 150 EXPECT_EQ(settings.xmpp_ping_timeout_sec(), 256);
149 151
150 // Set invalid settings, and check correct defaults. 152 // Set invalid settings, and check correct defaults.
151 settings.SetXmppPingTimeoutSec(1); 153 settings.SetXmppPingTimeoutSec(1);
152 EXPECT_EQ(settings.xmpp_ping_timeout_sec(), kMinXmppPingTimeoutSecs); 154 EXPECT_EQ(settings.xmpp_ping_timeout_sec(), kMinXmppPingTimeoutSecs);
153 } 155 }
154 156
155 } // namespace cloud_print 157 } // namespace cloud_print
OLDNEW
« no previous file with comments | « chrome/service/cloud_print/connector_settings.h ('k') | chrome/service/cloud_print/print_system_cups.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698