chrome/service/cloud_print/printer_job_queue_handler_unittest.cc - Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

Issue 1899083002: Convert //chrome from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/service/cloud_print/printer_job_queue_handler.h ('k') | chrome/service/net/service_url_request_context_getter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

diff --git a/chrome/service/cloud_print/printer_job_queue_handler_unittest.cc b/chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

index e9353fb12a0a503123600478f203ed7cf8e22a75..082ded03a0d2939f6fe9ce0563a6fbdb663fecbb 100644

--- a/chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

+++ b/chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

@@ -53,7 +53,7 @@ class TimeProviderMock : public PrinterJobQueueHandler::TimeProvider {

class PrinterJobQueueHandlerTest : public ::testing::Test {

protected:

- scoped_ptr<base::Value> data_;

+ std::unique_ptr<base::Value> data_;

const base::DictionaryValue* GetAsDictionary() const {

const base::DictionaryValue* json_data_ = nullptr;

« no previous file with comments | « chrome/service/cloud_print/printer_job_queue_handler.h ('k') | chrome/service/net/service_url_request_context_getter.h » ('j') | no next file with comments »