Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1899063002: Mark layer needsPaintPhaseFloat if a LayoutBlockFlow contains float (Closed)

Created:
4 years, 8 months ago by Xianzhu
Modified:
4 years, 8 months ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, slimming-paint-reviews_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark layer needsPaintPhaseFloat if a LayoutBlockFlow contains float This ensures that the flag is set on the correct layer that will paint the floats. BUG=603910 TEST=PaintLayerPainterTest.PaintPhaseFloatUnderInlineLayer Committed: https://crrev.com/0f04dfab4e324972733e1707476c034f52467037 Cr-Commit-Position: refs/heads/master@{#388644}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -6 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
4 years, 8 months ago (2016-04-19 18:20:10 UTC) #2
chrishtr
lgtm
4 years, 8 months ago (2016-04-20 23:16:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899063002/20001
4 years, 8 months ago (2016-04-20 23:17:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-21 00:45:32 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:29:37 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f04dfab4e324972733e1707476c034f52467037
Cr-Commit-Position: refs/heads/master@{#388644}

Powered by Google App Engine
This is Rietveld 408576698