Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp

Issue 1899063002: Mark layer needsPaintPhaseFloat if a LayoutBlockFlow contains float (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ight reserved. 3 * Copyright (C) 2003, 2004, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ight reserved.
4 * Copyright (C) 2010 Google Inc. All rights reserved. 4 * Copyright (C) 2010 Google Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 2081 matching lines...) Expand 10 before | Expand all | Expand 10 after
2092 2092
2093 void LayoutBlockFlow::invalidateDisplayItemClientsOfFirstLine() 2093 void LayoutBlockFlow::invalidateDisplayItemClientsOfFirstLine()
2094 { 2094 {
2095 ASSERT(childrenInline()); 2095 ASSERT(childrenInline());
2096 if (RootInlineBox* firstRootBox = this->firstRootBox()) 2096 if (RootInlineBox* firstRootBox = this->firstRootBox())
2097 firstRootBox->invalidateDisplayItemClientsRecursively(); 2097 firstRootBox->invalidateDisplayItemClientsRecursively();
2098 } 2098 }
2099 2099
2100 PaintInvalidationReason LayoutBlockFlow::invalidatePaintIfNeeded(const PaintInva lidationState& paintInvalidationState) 2100 PaintInvalidationReason LayoutBlockFlow::invalidatePaintIfNeeded(const PaintInva lidationState& paintInvalidationState)
2101 { 2101 {
2102 if (containsFloats())
2103 paintInvalidationState.enclosingSelfPaintingLayer(*this).setNeedsPaintPh aseFloat();
2104
2102 PaintInvalidationReason reason = LayoutBlock::invalidatePaintIfNeeded(paintI nvalidationState); 2105 PaintInvalidationReason reason = LayoutBlock::invalidatePaintIfNeeded(paintI nvalidationState);
2103 if (reason == PaintInvalidationNone) 2106 if (reason == PaintInvalidationNone)
2104 return reason; 2107 return reason;
2105 RootInlineBox* line = firstRootBox(); 2108 RootInlineBox* line = firstRootBox();
2106 if (!line || !line->isFirstLineStyle()) 2109 if (!line || !line->isFirstLineStyle())
2107 return reason; 2110 return reason;
2108 // It's the RootInlineBox that paints the ::first-line background. Note that since it may be 2111 // It's the RootInlineBox that paints the ::first-line background. Note that since it may be
2109 // expensive to figure out if the first line is affected by any ::first-line selectors at all, 2112 // expensive to figure out if the first line is affected by any ::first-line selectors at all,
2110 // we just invalidate it unconditionally, since that's typically cheaper. 2113 // we just invalidate it unconditionally, since that's typically cheaper.
2111 invalidateDisplayItemClient(*line); 2114 invalidateDisplayItemClient(*line);
2112 return reason; 2115 return reason;
2113 } 2116 }
2114 2117
2115 } // namespace blink 2118 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698