Mark layer needsPaintPhaseFloat if a LayoutBlockFlow contains float

third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "core/layout/LayoutBlock.h"
+#include "core/layout/LayoutInline.h"
 #include "core/layout/compositing/CompositedLayerMapping.h"
 #include "core/paint/PaintControllerPaintTest.h"
 #include "platform/graphics/GraphicsContext.h"
 
 namespace blink {
 
 class PaintLayerPainterTest
     : public PaintControllerPaintTest
     , public testing::WithParamInterface<FrameSettingOverrideFunction> {
     USING_FAST_MALLOC(PaintLayerPainterTest);
@@ skipping 297 matching lines @@
 
     // needsPaintPhaseFloat should be set when any descendant on the same layer has float.
     toHTMLElement(floatDiv.node())->setAttribute(HTMLNames::styleAttr, styleWithFloat);
     updateLifecyclePhasesBeforePaint();
     EXPECT_TRUE(selfPaintingLayer.needsPaintPhaseFloat());
     EXPECT_FALSE(nonSelfPaintingLayer.needsPaintPhaseFloat());
     paint();
     EXPECT_TRUE(displayItemListContains(rootPaintController().getDisplayItemList(), floatDiv, DisplayItem::BoxDecorationBackground));
 }
 
+TEST_P(PaintLayerPainterTest, PaintPhaseFloatUnderInlineLayer)
+{
+    setBodyInnerHTML(
+        "<div id='self-painting-layer' style='position: absolute'>"
+        "  <div id='non-self-painting-layer' style='overflow: hidden'>"
+        "    <span id='span' style='position: relative'>"
+        "      <div id='float' style='width: 10px; height: 10px; background-color: blue; float: left'></div>"
+        "    </span>"
+        "  </div>"
+        "</div>");
+    document().view()->updateAllLifecyclePhases();
+
+    LayoutObject& floatDiv = *document().getElementById("float")->layoutObject();
+    LayoutInline& span = *toLayoutInline(document().getElementById("span")->layoutObject());
+    PaintLayer& spanLayer = *span.layer();
+    ASSERT_TRUE(&spanLayer == floatDiv.enclosingLayer());
+    ASSERT_FALSE(spanLayer.needsPaintPhaseFloat());
+    LayoutBlock& selfPaintingLayerObject = *toLayoutBlock(document().getElementById("self-painting-layer")->layoutObject());
+    PaintLayer& selfPaintingLayer = *selfPaintingLayerObject.layer();
+    ASSERT_TRUE(selfPaintingLayer.isSelfPaintingLayer());
+    PaintLayer& nonSelfPaintingLayer = *toLayoutBoxModelObject(document().getElementById("non-self-painting-layer")->layoutObject())->layer();
+    ASSERT_FALSE(nonSelfPaintingLayer.isSelfPaintingLayer());
+
+    EXPECT_TRUE(selfPaintingLayer.needsPaintPhaseFloat());
+    EXPECT_FALSE(nonSelfPaintingLayer.needsPaintPhaseFloat());
+    EXPECT_FALSE(spanLayer.needsPaintPhaseFloat());
+    EXPECT_TRUE(displayItemListContains(rootPaintController().getDisplayItemList(), floatDiv, DisplayItem::BoxDecorationBackground));
+}
+
 TEST_P(PaintLayerPainterTest, PaintPhaseBlockBackground)
 {
     AtomicString styleWithoutBackground = "width: 50px; height: 50px";
     AtomicString styleWithBackground = "background: blue; " + styleWithoutBackground;
     setBodyInnerHTML(
         "<div id='self-painting-layer' style='position: absolute'>"
         "  <div id='non-self-painting-layer' style='overflow: hidden'>"
         "    <div>"
         "      <div id='background'></div>"
         "    </div>"
@@ skipping 82 matching lines @@
     document().view()->updateAllLifecyclePhases();
     ASSERT_TRUE(layerDiv.hasLayer());
     PaintLayer& layer = *layerDiv.layer();
     ASSERT_TRUE(layer.isSelfPaintingLayer());
     EXPECT_TRUE(layer.needsPaintPhaseDescendantOutlines());
     EXPECT_TRUE(layer.needsPaintPhaseFloat());
     EXPECT_TRUE(layer.needsPaintPhaseDescendantBlockBackgrounds());
 }
 
 } // namespace blink