Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1899033002: PPC: [Atomics] Remove Atomics code stubs; use TF ops (Closed)

Created:
4 years, 8 months ago by JaideepBajwa
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Atomics] Remove Atomics code stubs; use TF ops Port d412cfa26c18a6ef1f6c0e274ee51f3d834eab74 Original commit message: [Atomics] Remove Atomics code stubs; use TF ops Reland of (https://codereview.chromium.org/1891033002) This is a much cleaner solution, which won't require nearly as much architecture-specific code. Thanks bmeurer@! R=binji@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4614 LOG=N Committed: https://crrev.com/697c87414b775d10268339fcef3b1a58c186181d Cr-Commit-Position: refs/heads/master@{#35631}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix to address the comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 1 2 chunks +35 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
JaideepBajwa
PTAL
4 years, 8 months ago (2016-04-18 22:45:09 UTC) #1
MTBrandyberry
https://codereview.chromium.org/1899033002/diff/1/src/compiler/ppc/code-generator-ppc.cc File src/compiler/ppc/code-generator-ppc.cc (right): https://codereview.chromium.org/1899033002/diff/1/src/compiler/ppc/code-generator-ppc.cc#newcode681 src/compiler/ppc/code-generator-ppc.cc:681: MemOperand(i.InputRegister(0), i.InputRegister(1))); \ If you want to support the ...
4 years, 8 months ago (2016-04-19 14:13:08 UTC) #2
MTBrandyberry
lgtm
4 years, 8 months ago (2016-04-19 15:24:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899033002/20001
4 years, 8 months ago (2016-04-19 16:30:28 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 16:53:40 UTC) #6
nodir1
4 years, 8 months ago (2016-04-22 18:43:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/697c87414b775d10268339fcef3b1a58c186181d
Cr-Commit-Position: refs/heads/master@{#35631}

Powered by Google App Engine
This is Rietveld 408576698