Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1891033002: [Atomics] Remove Atomics code stubs; use TF ops (Closed)

Created:
4 years, 8 months ago by binji
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Atomics] Remove Atomics code stubs; use TF ops This is a much cleaner solution, which won't require nearly as much architecture-specific code. Thanks bmeurer@! BUG=v8:4614 LOG=y R=bmeurer@chromium.org,jarin@chromium.org Committed: https://crrev.com/6ff5881b1def45b35384572f61327e42563a89c3 Cr-Commit-Position: refs/heads/master@{#35547}

Patch Set 1 #

Patch Set 2 : fix arm/mips compile #

Patch Set 3 : fix unused variables #

Total comments: 2

Patch Set 4 : fix arm64 #

Patch Set 5 : merge master #

Patch Set 6 : remove s390 code stub #

Unified diffs Side-by-side diffs Delta from patch set Stats (+292 lines, -1120 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 1 chunk +0 lines, -161 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 3 4 1 chunk +0 lines, -139 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/builtins.cc View 4 chunks +63 lines, -15 lines 0 comments Download
M src/code-factory.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-factory.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 2 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 2 chunks +23 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 2 3 2 chunks +24 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 1 chunk +27 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 2 3 4 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 4 chunks +34 lines, -1 line 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -170 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 3 4 1 chunk +0 lines, -9 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +1 line, -7 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 1 chunk +0 lines, -187 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 2 3 4 5 1 chunk +0 lines, -176 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 2 3 4 5 1 chunk +0 lines, -8 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -164 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
binji
PTAL
4 years, 8 months ago (2016-04-14 22:16:50 UTC) #3
Benedikt Meurer
Woohoo, awesome! LGTM.
4 years, 8 months ago (2016-04-15 06:59:13 UTC) #4
Rodolph Perfetta
DBC https://codereview.chromium.org/1891033002/diff/40001/src/compiler/arm64/code-generator-arm64.cc File src/compiler/arm64/code-generator-arm64.cc (right): https://codereview.chromium.org/1891033002/diff/40001/src/compiler/arm64/code-generator-arm64.cc#newcode1427 src/compiler/arm64/code-generator-arm64.cc:1427: ASSEMBLE_ATOMIC_LOAD_INTEGER(Ldr); For Ldrb/sb/h/sh the amount of data loaded ...
4 years, 8 months ago (2016-04-15 14:36:04 UTC) #6
binji
https://codereview.chromium.org/1891033002/diff/40001/src/compiler/arm64/code-generator-arm64.cc File src/compiler/arm64/code-generator-arm64.cc (right): https://codereview.chromium.org/1891033002/diff/40001/src/compiler/arm64/code-generator-arm64.cc#newcode1427 src/compiler/arm64/code-generator-arm64.cc:1427: ASSEMBLE_ATOMIC_LOAD_INTEGER(Ldr); On 2016/04/15 14:36:03, Rodolph Perfetta wrote: > For ...
4 years, 8 months ago (2016-04-15 21:00:13 UTC) #7
binji
FYI: mbrandy@, jyan@. sorry for the churn
4 years, 8 months ago (2016-04-15 21:05:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891033002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891033002/100001
4 years, 8 months ago (2016-04-15 21:05:52 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-04-16 06:47:44 UTC) #13
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/6ff5881b1def45b35384572f61327e42563a89c3 Cr-Commit-Position: refs/heads/master@{#35547}
4 years, 8 months ago (2016-04-16 06:49:14 UTC) #15
Michael Achenbach
4 years, 8 months ago (2016-04-16 13:11:05 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1895643002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20....

Powered by Google App Engine
This is Rietveld 408576698