chrome/browser/ui/views/website_settings/permission_selector_view.cc - Issue 1898633004: Views: Add new SetFocusBehavior method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 1898633004: Views: Add new SetFocusBehavior method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/find_bar_view.cc ('K') | « chrome/browser/ui/views/website_settings/chosen_object_view.cc ('k') | ui/app_list/views/custom_launcher_page_view.cc » ('j') | ui/views/controls/label_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/website_settings/permission_selector_view.cc

diff --git a/chrome/browser/ui/views/website_settings/permission_selector_view.cc b/chrome/browser/ui/views/website_settings/permission_selector_view.cc

index 1968f3c90bc59e2cc118219f4afeecc69ce5ec55..91ddd972a05a502255e7304631a0792299ea51af 100644

--- a/chrome/browser/ui/views/website_settings/permission_selector_view.cc

+++ b/chrome/browser/ui/views/website_settings/permission_selector_view.cc

@@ -178,7 +178,7 @@ PermissionSelectorView::PermissionSelectorView(

permission.source),

menu_model_.get(), button_enabled);

menu_button_->SetEnabled(button_enabled);

- menu_button_->SetFocusable(button_enabled);

+ menu_button_->SetFocusBehavior(FocusBehavior::ALWAYS);

tapted 2016/04/20 04:16:28 This works, but it might make more sense in the Pe

karandeepb 2016/04/21 03:16:33 Done. This class is only instantiated once, so eit

menu_button_->SetAccessibleName(

WebsiteSettingsUI::PermissionTypeToUIString(permission.type));

layout->AddView(menu_button_);