Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Side by Side Diff: chrome/browser/ui/views/website_settings/permission_selector_view.cc

Issue 1898633004: Views: Add new SetFocusBehavior method. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/website_settings/permission_selector_view.h" 5 #include "chrome/browser/ui/views/website_settings/permission_selector_view.h"
6 6
7 #include "base/i18n/rtl.h" 7 #include "base/i18n/rtl.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h " 10 #include "chrome/browser/ui/views/website_settings/website_settings_popup_view.h "
(...skipping 160 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 base::Unretained(this)))); 171 base::Unretained(this))));
172 // Create the permission menu button. 172 // Create the permission menu button.
173 bool button_enabled = 173 bool button_enabled =
174 permission.source == content_settings::SETTING_SOURCE_USER; 174 permission.source == content_settings::SETTING_SOURCE_USER;
175 menu_button_ = new internal::PermissionMenuButton( 175 menu_button_ = new internal::PermissionMenuButton(
176 WebsiteSettingsUI::PermissionActionToUIString( 176 WebsiteSettingsUI::PermissionActionToUIString(
177 permission.type, permission.setting, permission.default_setting, 177 permission.type, permission.setting, permission.default_setting,
178 permission.source), 178 permission.source),
179 menu_model_.get(), button_enabled); 179 menu_model_.get(), button_enabled);
180 menu_button_->SetEnabled(button_enabled); 180 menu_button_->SetEnabled(button_enabled);
181 menu_button_->SetFocusable(button_enabled); 181 menu_button_->SetFocusBehavior(FocusBehavior::ALWAYS);
tapted 2016/04/20 04:16:28 This works, but it might make more sense in the Pe
karandeepb 2016/04/21 03:16:33 Done. This class is only instantiated once, so eit
182 menu_button_->SetAccessibleName( 182 menu_button_->SetAccessibleName(
183 WebsiteSettingsUI::PermissionTypeToUIString(permission.type)); 183 WebsiteSettingsUI::PermissionTypeToUIString(permission.type));
184 layout->AddView(menu_button_); 184 layout->AddView(menu_button_);
185 } 185 }
186 186
187 void PermissionSelectorView::AddObserver( 187 void PermissionSelectorView::AddObserver(
188 PermissionSelectorViewObserver* observer) { 188 PermissionSelectorViewObserver* observer) {
189 observer_list_.AddObserver(observer); 189 observer_list_.AddObserver(observer);
190 } 190 }
191 191
(...skipping 18 matching lines...) Expand all
210 // Update the menu button text to reflect the new setting. 210 // Update the menu button text to reflect the new setting.
211 menu_button_->SetText(WebsiteSettingsUI::PermissionActionToUIString( 211 menu_button_->SetText(WebsiteSettingsUI::PermissionActionToUIString(
212 permission.type, permission.setting, permission.default_setting, 212 permission.type, permission.setting, permission.default_setting,
213 content_settings::SETTING_SOURCE_USER)); 213 content_settings::SETTING_SOURCE_USER));
214 menu_button_->SizeToPreferredSize(); 214 menu_button_->SizeToPreferredSize();
215 215
216 FOR_EACH_OBSERVER(PermissionSelectorViewObserver, 216 FOR_EACH_OBSERVER(PermissionSelectorViewObserver,
217 observer_list_, 217 observer_list_,
218 OnPermissionChanged(permission)); 218 OnPermissionChanged(permission));
219 } 219 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698