Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h

Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0039-picasa-import-sandbox-ini-parsing
Patch Set: Nevermind. Can't be done. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h
diff --git a/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h b/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h
index 983652ce2921e6a3dbb300b46c5940302e209ca0..07f932c40960d2889e9b521f8ebd20e0ec8d9f55 100644
--- a/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h
+++ b/chrome/browser/media_galleries/fileapi/safe_picasa_albums_indexer.h
@@ -10,6 +10,7 @@
#include "base/callback.h"
#include "base/compiler_specific.h"
+#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "chrome/common/media_galleries/picasa_types.h"
#include "content/public/browser/utility_process_host_client.h"
@@ -24,6 +25,8 @@ class Message;
namespace picasa {
+extern const char kPicasaINIFilename[];
+
// SafePicasaAlbumsIndexer indexes the contents of Picasa Albums by parsing the
// INI files found in Folders. The SafePicasaAlbumsIndexer object is ref-counted
// and kept alive after Start() is called until the ParserCallback is called.
@@ -31,8 +34,12 @@ namespace picasa {
// utility process replies or when it dies.
class SafePicasaAlbumsIndexer : public content::UtilityProcessHostClient {
public:
- typedef base::Callback<void(bool /* success */,
- const picasa::AlbumImagesMap&)> DoneCallback;
+ // Callback includes a refptr to itself to guarantee that this object
+ // survives past the execution of its last posted callback.
+ typedef base::Callback<void(scoped_refptr<SafePicasaAlbumsIndexer>,
+ bool success,
+ const picasa::AlbumImagesMap&)>
+ DoneCallback;
SafePicasaAlbumsIndexer(const AlbumMap& albums,
const AlbumMap& folders,

Powered by Google App Engine
This is Rietveld 408576698