chrome/common/media_galleries/picasa_types.h - Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/media_galleries/picasa_types.h

Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0039-picasa-import-sandbox-ini-parsing

Patch Set: Nevermind. Can't be done. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h ('K') | « chrome/chrome_tests.gypi ('k') | chrome/utility/media_galleries/picasa_album_table_reader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/media_galleries/picasa_types.h

diff --git a/chrome/common/media_galleries/picasa_types.h b/chrome/common/media_galleries/picasa_types.h

index e807bc18af6ae69b4739e4688269a2ebc8d29e8a..6bdadc49d0d251f1cd6752a59dad75e4f9434897 100644

--- a/chrome/common/media_galleries/picasa_types.h

+++ b/chrome/common/media_galleries/picasa_types.h

@@ -24,6 +24,12 @@ typedef std::map<std::string, AlbumInfo> AlbumMap;

const char kPicasaAlbumTableName[] = "albumdata";

vandebo (ex-Chrome) 2013/08/14 23:48:11 Don't you want these to be extern with the definit

tommycli 2013/08/15 22:52:36 Done. The numbers were used in a switch statement,

vandebo (ex-Chrome) 2013/08/22 17:48:02 Tommy looking into prevalent style.

tommycli 2013/08/22 22:32:50 Done.

+const uint32 kAlbumCategoryAlbum = 0;

+const uint32 kAlbumCategoryFolder = 2;

+const uint32 kAlbumCategoryInvalid = 0xffff; // Sentinel value.

+const char kAlbumTokenPrefix[] = "]album:";

struct AlbumInfo {

AlbumInfo();

AlbumInfo(const std::string& name, const base::Time& timestamp,