chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h - Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly.

Unified Diff: chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

Issue 18986012: Media Galleries API Picasa: Make PicasaDataProvider handle async PMP and INI parsing robustly. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0039-picasa-import-sandbox-ini-parsing

Patch Set: Nevermind. Can't be done. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media_galleries/fileapi/picasa/picasa_data_provider_browsertest.cc ('K') | « chrome/browser/media_galleries/fileapi/picasa/picasa_file_util_unittest.cc ('k') | chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.cc » ('j') | chrome/common/media_galleries/picasa_types.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

diff --git a/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h b/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

index 7ba576488449cf510a6d72b6220f139ee9ebf27d..94a12aa7dea947f6fec562967ae87ff8225671cf 100644

--- a/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

+++ b/chrome/browser/media_galleries/fileapi/safe_picasa_album_table_reader.h

@@ -31,7 +31,10 @@ namespace picasa {

// utility process replies or when it dies.

class SafePicasaAlbumTableReader : public content::UtilityProcessHostClient {

public:

- typedef base::Callback<void(bool,

+ // Callback includes a refptr to itself to guarantee that this object

+ // survives past the execution of its last posted callback.

+ typedef base::Callback<void(scoped_refptr<SafePicasaAlbumTableReader>,

vandebo (ex-Chrome) 2013/08/14 23:48:11 I don't think there's a good reason to include thi

tommycli 2013/08/15 22:52:36 PicasaDataProvider also needs to keep a reference

vandebo (ex-Chrome) 2013/08/22 17:48:02 Per offline discussion, Tommy looking into this ag

tommycli 2013/08/22 22:32:50 Done.

+ bool,

vandebo (ex-Chrome) 2013/08/14 23:48:11 nit: name this since it's unclear without a name.

tommycli 2013/08/15 22:52:36 Done.

const std::vector<AlbumInfo>&,

const std::vector<AlbumInfo>&)> ParserCallback;