Trace where timers were scheduled in Blink

Trace where timers were scheduled in Blink

This required adding a TraceLocation class
modeled after base::Location in Chromium.

This makes TraceLocation a required parameter
to all Timer::start* calls.

BUG=350592
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168858

[eseidel, 2014-03-08 10:03:11]

This should allow us to more easily see what's scheduling all the timers in
Blink from trace files.

[eseidel, 2014-03-08 10:14:53]

https://codereview.chromium.org/189833009/diff/10001/Source/core/loader/PingL...
File Source/core/loader/PingLoader.cpp (right):

https://codereview.chromium.org/189833009/diff/10001/Source/core/loader/PingL...
Source/core/loader/PingLoader.cpp:144: m_timeout.startOneShot(60000, FROM_HERE);
This 16.7 hour timer is definitely my favorite timer in Blink.  I suspect that
Nate meant for this to be 1 minute and didn't realize that Timer takes seconds
instead of milliseconds. :)

[eseidel, 2014-03-08 10:14:53]

https://codereview.chromium.org/189833009/diff/10001/Source/core/loader/PingL...
File Source/core/loader/PingLoader.cpp (right):

https://codereview.chromium.org/189833009/diff/10001/Source/core/loader/PingL...
Source/core/loader/PingLoader.cpp:144: m_timeout.startOneShot(60000, FROM_HERE);
This 16.7 hour timer is definitely my favorite timer in Blink.  I suspect that
Nate meant for this to be 1 minute and didn't realize that Timer takes seconds
instead of milliseconds. :)

[philipj_slow, 2014-03-08 10:18:52]

Non-owner LGTM from HTML*Element

[abarth-chromium, 2014-03-09 22:19:09]

rslgtm

https://codereview.chromium.org/189833009/diff/10001/Source/platform/AsyncMet...
File Source/platform/AsyncMethodRunner.h (right):

https://codereview.chromium.org/189833009/diff/10001/Source/platform/AsyncMet...
Source/platform/AsyncMethodRunner.h:68: m_timer.startOneShot(0, FROM_HERE);
This one isn't very useful  :)

https://codereview.chromium.org/189833009/diff/10001/Source/platform/TraceLoc...
File Source/platform/TraceLocation.h (right):

https://codereview.chromium.org/189833009/diff/10001/Source/platform/TraceLoc...
Source/platform/TraceLocation.h:14: class PLATFORM_EXPORT TraceLocation {
No need to export a lass that's entirely inline.

If you keep the export macro, you should include the header that defines it.  :)

[Stephen Chennney, 2014-03-10 14:33:34]

On 2014/03/09 22:19:09, abarth wrote:
>
https://codereview.chromium.org/189833009/diff/10001/Source/platform/TraceLoc...
> Source/platform/TraceLocation.h:14: class PLATFORM_EXPORT TraceLocation {
> No need to export a lass that's entirely inline.

I don't think it's ever legal to export a lass.

Sorry, couldn't resist.

[eseidel, 2014-03-10 18:08:01]

The CQ bit was checked by eseidel@chromium.org

[commit-bot: I haz the power, 2014-03-10 18:08:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eseidel@chromium.org/189833009/10002

[jamesr, 2014-03-10 19:41:51]

nice!

https://codereview.chromium.org/189833009/diff/10002/Source/platform/TraceLoc...
File Source/platform/TraceLocation.h (right):

https://codereview.chromium.org/189833009/diff/10002/Source/platform/TraceLoc...
Source/platform/TraceLocation.h:16: // Currenetly only store the bits used in
Blink, base::Location stores more.
Currently

[commit-bot: I haz the power, 2014-03-10 19:51:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-10 19:51:36]

Try jobs failed on following builders: linux_blink

[eseidel, 2014-03-10 20:04:15]

There appears to be a marauding failure in timeline/inspector.  I got a
different test to fail when running locally.  I don't believe it's related to my
patch?

[eseidel, 2014-03-10 20:13:49]

Committed patchset #4 manually as r168858 (presubmit successful).