Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1898263002: bluetooth: Separate connection tests (Closed)

Created:
4 years, 8 months ago by ortuno
Modified:
4 years, 7 months ago
Reviewers:
Jeffrey Yasskin
CC:
blink-reviews, chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-separate-tests-get-primary-service
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Separate connection tests and fix one writeValue test BUG=554240 Committed: https://crrev.com/69cf3eda0120e60cba9413eff1cf7e31dcd3b5b1 Cr-Commit-Position: refs/heads/master@{#391554}

Patch Set 1 #

Patch Set 2 : Merge #

Patch Set 3 : Separate disconnect tests #

Patch Set 4 : Fix connection fails test #

Total comments: 4

Patch Set 5 : Add name to test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -423 lines) Patch
D third_party/WebKit/LayoutTests/bluetooth/connect.html View 1 chunk +0 lines, -154 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/connect/connectGATT.html View 1 chunk +5 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/connect/connection-fails.html View 1 2 3 3 chunks +29 lines, -66 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/connect/connection-succeeds.html View 1 chunk +2 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/connect/device-goes-out-of-range.html View 1 chunk +2 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html View 1 2 3 4 1 chunk +6 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/disconnect.html View 1 2 1 chunk +0 lines, -54 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/detach-gc.html View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/gc-detach.html View 1 2 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/hide-detach.html View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/disconnect/connect-disconnect-twice.html View 1 2 1 chunk +11 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/disconnect/detach-gc.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/disconnect/disconnect-once.html View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/disconnect/disconnect-twice-in-a-row.html View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/disconnect/gc-detach.html View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/bluetooth/writeValue/write-fails.html View 1 chunk +16 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898263002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898263002/60001
4 years, 7 months ago (2016-05-03 20:05:19 UTC) #3
ortuno
jyasskin: PTAL
4 years, 7 months ago (2016-05-03 20:46:57 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-03 21:15:11 UTC) #7
Jeffrey Yasskin
lgtm https://codereview.chromium.org/1898263002/diff/60001/third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html File third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html (right): https://codereview.chromium.org/1898263002/diff/60001/third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html#newcode16 third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html:16: }); Please add a name for this test. ...
4 years, 7 months ago (2016-05-04 00:49:32 UTC) #8
ortuno
Thanks! https://codereview.chromium.org/1898263002/diff/60001/third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html File third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html (right): https://codereview.chromium.org/1898263002/diff/60001/third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html#newcode16 third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html:16: }); On 2016/05/04 at 00:49:32, Jeffrey Yasskin wrote: ...
4 years, 7 months ago (2016-05-04 16:41:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1898263002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1898263002/80001
4 years, 7 months ago (2016-05-04 16:42:07 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-05-04 17:49:05 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 17:50:14 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/69cf3eda0120e60cba9413eff1cf7e31dcd3b5b1
Cr-Commit-Position: refs/heads/master@{#391554}

Powered by Google App Engine
This is Rietveld 408576698