third_party/WebKit/LayoutTests/bluetooth/connect/connectGATT.html - Issue 1898263002: bluetooth: Separate connection tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/connect/connectGATT.html

Issue 1898263002: bluetooth: Separate connection tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-separate-tests-get-primary-service

Patch Set: Add name to test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/connect.html ('k') | third_party/WebKit/LayoutTests/bluetooth/connect/connection-fails.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/bluetooth/connect/connectGATT.html

diff --git a/third_party/WebKit/LayoutTests/bluetooth/notifications/stop-without-starting.html b/third_party/WebKit/LayoutTests/bluetooth/connect/connectGATT.html

similarity index 57%

copy from third_party/WebKit/LayoutTests/bluetooth/notifications/stop-without-starting.html

copy to third_party/WebKit/LayoutTests/bluetooth/connect/connectGATT.html

index 7cbb02923277a8249db0a1bc80b9830129cd2025..28de6d9c4af9c012bc8ad89167d25c11aa8308f1 100644

--- a/third_party/WebKit/LayoutTests/bluetooth/notifications/stop-without-starting.html

+++ b/third_party/WebKit/LayoutTests/bluetooth/connect/connectGATT.html

@@ -4,13 +4,12 @@

'use strict';

+// TODO(ortuno): Remove connectGATT in M52.

+// http://crbug.com/582292

promise_test(() => {

return setBluetoothFakeAdapter('HeartRateAdapter')

.then(() => requestDeviceWithKeyDown({

filters: [{services: ['heart_rate']}]}))

- .then(device => device.gatt.connect())

- .then(gattServer => gattServer.getPrimaryService('heart_rate'))

- .then(service => service.getCharacteristic('heart_rate_measurement'))

- .then(characteristic => characteristic.stopNotifications());

-}, "Stop without starting.");

-</script>

+ .then(device => device.connectGATT())

+}, 'Make sure deprecated method is still usable.')

+</script></script>