third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html - Issue 1898263002: bluetooth: Separate connection tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/connect/get-same-gatt-server.html

Issue 1898263002: bluetooth: Separate connection tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-separate-tests-get-primary-service

Patch Set: Fix connection fails test Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/bluetooth/connect/device-goes-out-of-range.html ('k') | third_party/WebKit/LayoutTests/bluetooth/disconnect.html » ('j') | third_party/WebKit/LayoutTests/bluetooth/disconnect-frame-detached/hide-detach.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../resources/testharness.js"></script>	2 <script src="../../resources/testharness.js"></script>

3 <script src="../../resources/testharnessreport.js"></script>	3 <script src="../../resources/testharnessreport.js"></script>

4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>	4 <script src="../../resources/bluetooth/bluetooth-helpers.js"></script>

5 <script>	5 <script>

6 'use strict';	6 'use strict';

7 promise_test(() => {	7 promise_test(() => {

8 return setBluetoothFakeAdapter('HeartRateAdapter')	8 return setBluetoothFakeAdapter('HeartRateAdapter')

9 .then(() => requestDeviceWithKeyDown({	9 .then(() => requestDeviceWithKeyDown({

10 filters: [{services: ['heart_rate']}]}))	10 filters: [{services: ['heart_rate']}]}))

11 .then(device => device.gatt.connect())	11 .then(device => {

12 .then(gattServer => gattServer.getPrimaryService('heart_rate'))	12 return Promise.all([device.gatt.connect(), device.gatt.connect()])

13 .then(service => service.getCharacteristic('heart_rate_measurement'))	13 }).then(gattServers => {

14 .then(characteristic => characteristic.stopNotifications());	14 assert_equals(gattServers[0], gattServers[1]);

15 }, "Stop without starting.");	15 });

	16 });
	Jeffrey Yasskin 2016/05/04 00:49:32 Please add a name for this test. Maybe "Multiple c Please add a name for this test. Maybe "Multiple connects return same object." ortuno 2016/05/04 16:41:50 Done. Show quoted text On 2016/05/04 at 00:49:32, Jeffrey Yasskin wrote: > Please add a name for this test. Maybe "Multiple connects return same object." Done.
16 </script>	17 </script>

OLD	NEW