Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1897293002: Throw error if timeConstant is not positive for setTargetAtTime (Closed)

Created:
4 years, 8 months ago by Raymond Toy
Modified:
4 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews, haraken, hongchan, Raymond Toy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Throw error if timeConstant is not positive for setTargetAtTime If the timeConstant is not strictly positive, setTargetAtTime should throw an error. BUG=604775 TEST=audioparam-exceptional-values.html updated with new test Committed: https://crrev.com/3890633d575fd3a0ac412570e0bfa015bec58c95 Cr-Commit-Position: refs/heads/master@{#388560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values.html View 2 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Raymond Toy
PTAL
4 years, 8 months ago (2016-04-19 16:16:12 UTC) #2
hongchan
lgtm
4 years, 8 months ago (2016-04-20 16:19:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897293002/1
4 years, 8 months ago (2016-04-20 16:26:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/124875) chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-20 16:30:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897293002/1
4 years, 8 months ago (2016-04-20 18:25:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 20:06:13 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3890633d575fd3a0ac412570e0bfa015bec58c95 Cr-Commit-Position: refs/heads/master@{#388560}
4 years, 8 months ago (2016-04-22 19:25:51 UTC) #12
Raymond Toy
4 years, 8 months ago (2016-04-25 17:28:27 UTC) #13
Message was sent while issue was closed.
Oops.  The actual bug is 604755, not 604775.

Powered by Google App Engine
This is Rietveld 408576698