Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values.html

Issue 1897293002: Throw error if timeConstant is not positive for setTargetAtTime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values.html b/third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values.html
index 535faf7df76b74a2ed4f43ac810151bb3bbb90e9..1f57b499ecf66b246a8153ef8fefaee59d450efc 100644
--- a/third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values.html
+++ b/third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values.html
@@ -24,6 +24,10 @@
// invalid. Only finite values are allowed for any duration parameter.
var durationValues = [-1, Infinity, -Infinity, NaN, 0];
+ // For these timeConstant values for setTargetAtTime an error must be thrown because they are
+ // invalid.
+ var timeConstantValues = [-1, 0, Infinity, -Infinity, NaN];
+
// Just an array for use by setValueCurveAtTime. The length and contents of the array are not
// important.
var curve = new Float32Array(10);
@@ -55,7 +59,7 @@
}
// Test time constant
- for (value of targetValues) {
+ for (value of timeConstantValues) {
shouldThrow("gain.gain.setTargetAtTime(1, 1, " + value + ")");
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698