Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp

Issue 1897293002: Throw error if timeConstant is not positive for setTargetAtTime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
diff --git a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
index 58646b6be17ab91a0ad3748670b4887d585496d8..8b5aae49fc2d1c6a39695d69c4e656457e67507d 100644
--- a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
+++ b/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
@@ -179,7 +179,7 @@ void AudioParamTimeline::setTargetAtTime(float target, double time, double timeC
ASSERT(isMainThread());
if (!isNonNegativeAudioParamTime(time, exceptionState)
- || !isNonNegativeAudioParamTime(timeConstant, exceptionState, "Time constant"))
+ || !isPositiveAudioParamTime(timeConstant, exceptionState, "Time constant"))
return;
insertEvent(ParamEvent::createSetTargetEvent(target, time, timeConstant), exceptionState);
« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/audioparam-exceptional-values-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698