Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1896623002: Setting TestRunner's main window from BlinkTestRunner. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 7 months ago
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, Peter Beverloo, site-isolation-reviews_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@replicate-across-all-renderers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure TestRunner::topLoadingFrame is from the main test window. Before this CL, TestRunner::web_view_ would always be set to the first WebView/RenderView created in the given renderer process. This has been interfering with TestRunner::topLoadingFrame tracking - in OOPIF modes this might be tracking a frame not belonging to the main window. BUG=595089 Committed: https://crrev.com/8973c521e42739f6c2d1e1b3c8fa7c6e90753014 Cr-Commit-Position: refs/heads/master@{#390097}

Patch Set 1 #

Patch Set 2 : Rebasing... #

Patch Set 3 : Rebasing... #

Patch Set 4 : Rebasing... #

Patch Set 5 : Rebasing... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -62 lines) Patch
M components/test_runner/test_interfaces.h View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M components/test_runner/test_interfaces.cc View 1 3 chunks +9 lines, -5 lines 0 comments Download
M components/test_runner/test_runner.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M components/test_runner/test_runner.cc View 1 2 3 4 7 chunks +27 lines, -14 lines 0 comments Download
M components/test_runner/web_test_interfaces.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/test_runner/web_test_interfaces.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 1 2 3 2 chunks +14 lines, -19 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_thread_observer.h View 1 3 chunks +0 lines, -7 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_render_thread_observer.cc View 1 3 chunks +1 line, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Łukasz Anforowicz
jochen@, could you please take a look?
4 years, 8 months ago (2016-04-23 04:04:48 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 7 months ago (2016-04-27 11:58:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896623002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896623002/80001
4 years, 7 months ago (2016-04-27 15:06:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-27 15:55:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896623002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896623002/80001
4 years, 7 months ago (2016-04-27 16:27:18 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 7 months ago (2016-04-27 16:32:38 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:10:27 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8973c521e42739f6c2d1e1b3c8fa7c6e90753014
Cr-Commit-Position: refs/heads/master@{#390097}

Powered by Google App Engine
This is Rietveld 408576698