content/shell/renderer/layout_test/blink_test_runner.cc - Issue 1896623002: Setting TestRunner's main window from BlinkTestRunner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/renderer/layout_test/blink_test_runner.cc

Issue 1896623002: Setting TestRunner's main window from BlinkTestRunner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@replicate-across-all-renderers

Patch Set: Rebasing... Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/web_test_interfaces.cc ('k') | content/shell/renderer/layout_test/layout_test_content_renderer_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/renderer/layout_test/blink_test_runner.cc

diff --git a/content/shell/renderer/layout_test/blink_test_runner.cc b/content/shell/renderer/layout_test/blink_test_runner.cc

index 8e3db1798c86c7ae1dcec87ce99935c45dd6f3b0..e90df06ff122e9fae4c106f6586ce73609e9aa6f 100644

--- a/content/shell/renderer/layout_test/blink_test_runner.cc

+++ b/content/shell/renderer/layout_test/blink_test_runner.cc

@@ -892,11 +892,14 @@ void BlinkTestRunner::OnSetupSecondaryRenderer() {

void BlinkTestRunner::OnReplicateTestConfiguration(

const ShellTestConfiguration& params) {

+ test_runner::WebTestInterfaces* interfaces =

+ LayoutTestRenderThreadObserver::GetInstance()->test_interfaces();

test_config_ = params;

is_main_window_ = true;

+ interfaces->SetMainView(render_view()->GetWebView());

- test_runner::WebTestInterfaces* interfaces =

- LayoutTestRenderThreadObserver::GetInstance()->test_interfaces();

interfaces->SetTestIsRunning(true);

interfaces->ConfigureForTestWithURL(params.test_url,

params.enable_pixel_dumping);