Split TestRunner::setTopLoadingFrame into separate "set" and "clear" methods.

Split TestRunner::setTopLoadingFrame into separate "set" and "clear" methods.

BUG=595089
Committed: https://crrev.com/10cd87645bc101283ca7f741977c68d9a1ac9644
Cr-Commit-Position: refs/heads/master@{#390160}

[Łukasz Anforowicz, 2016-04-25 23:09:17]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-04-25 23:09:18]

jochen@, could you please take a look?  This mini refactoring is not strictly
required, but it makes it much easier to see what is getting changed in the
subsequent CL - https://codereview.chromium.org/1908233002/

[jochen (gone - plz use gerrit), 2016-04-27 11:59:08]

lgtm anyway

https://codereview.chromium.org/1893783002/diff/60001/components/test_runner/...
File components/test_runner/test_runner.h (right):

https://codereview.chromium.org/1893783002/diff/60001/components/test_runner/...
components/test_runner/test_runner.h:139: void
tryToSetTopLoadingFrame(blink::WebFrame*);
should this and the next return a bool whether it was successful? just for API
niceness...

[Łukasz Anforowicz, 2016-04-27 17:06:53]

Thanks for reviewing.

https://codereview.chromium.org/1893783002/diff/60001/components/test_runner/...
File components/test_runner/test_runner.h (right):

https://codereview.chromium.org/1893783002/diff/60001/components/test_runner/...
components/test_runner/test_runner.h:139: void
tryToSetTopLoadingFrame(blink::WebFrame*);
On 2016/04/27 11:59:08, jochen wrote:
> should this and the next return a bool whether it was successful? just for API
> niceness...

Done (+ added comments explaining this and other aspects of the behavior).

https://codereview.chromium.org/1893783002/diff/80001/components/test_runner/...
File components/test_runner/test_runner.h (right):

https://codereview.chromium.org/1893783002/diff/80001/components/test_runner/...
components/test_runner/test_runner.h:545: bool
IsFramePartOfMainTestWindow(blink::WebFrame*) const;
This belongs in "private" part of TestRunner class (I moved it here compared to
the previous patchset + named the method following Chromium, rather than Blink
style).

[Łukasz Anforowicz, 2016-04-27 19:11:51]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-04-27 19:11:51]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1893783002/#ps100001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-04-27 19:12:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1893783002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1893783002/100001

[commit-bot: I haz the power, 2016-04-27 20:03:11]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-30 17:12:20]

Patchset 6 (id:??) landed as
https://crrev.com/10cd87645bc101283ca7f741977c68d9a1ac9644
Cr-Commit-Position: refs/heads/master@{#390160}

[commit-bot: I haz the power, 2016-04-30 17:51:27]

Description was changed from

==========
Split TestRunner::setTopLoadingFrame into separate "set" and "clear" methods.

BUG=595089
==========

to

==========
Split TestRunner::setTopLoadingFrame into separate "set" and "clear" methods.

BUG=595089

Committed: https://crrev.com/10cd87645bc101283ca7f741977c68d9a1ac9644
Cr-Commit-Position: refs/heads/master@{#390160}
==========