Use correct WebView from TextInputController.

Use correct WebView from TextInputController.

Before this CL TextInputController would act on the WebView
associated with the main test window, rather than acting on the WebView
associated with the frame owning the TextInputController's
javascript bindings.  This could potentially lead to UaF
(there is no known repro though at the moment).

Changes in the current CL:
- TextInputController's lifetime is now owned by WebViewTestProxy
  (rather than having TextInputController owned by the global
  TestInterfaces object).
- TextInputController now uses WebView from the correct
  WebViewTestProxy (rather than one associted with the main test window).
- TestInterfaces object no longer has a pointer to an
  TextInputController object (because there is no longer a
  central/global TextInputController object).  This means having to
  move code that calls TextInputController::Install away
  from TestInterfaces.

Additional changes:
- TextInputController does not need to inherit from
  base::SupportsWeakPtr<...> (because TextInputController already
  has a weak_factory_ field).

BUG=595089
Committed: https://crrev.com/8b6d5f3c021f312bb13f4a4cf2c04bd8f1c5187f
Cr-Commit-Position: refs/heads/master@{#389142}

[Łukasz Anforowicz, 2016-04-21 23:03:10]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-04-21 23:03:10]

jochen@, could you please take a look?

[jochen (gone - plz use gerrit), 2016-04-22 15:24:32]

lgtm

[Łukasz Anforowicz, 2016-04-22 16:05:32]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 16:06:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896413003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896413003/60001

[commit-bot: I haz the power, 2016-04-22 16:40:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 16:40:18]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-04-22 16:51:20]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-22 16:51:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1896413003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1896413003/60001

[commit-bot: I haz the power, 2016-04-22 16:56:42]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-22 19:48:51]

Description was changed from

==========
Use correct WebView from TextInputController.

Before this CL TextInputController would act on the WebView
associated with the main test window, rather than acting on the WebView
associated with the frame owning the TextInputController's
javascript bindings.  This could potentially lead to UaF
(there is no known repro though at the moment).

Changes in the current CL:
- TextInputController's lifetime is now owned by WebViewTestProxy
  (rather than having TextInputController owned by the global
  TestInterfaces object).
- TextInputController now uses WebView from the correct
  WebViewTestProxy (rather than one associted with the main test window).
- TestInterfaces object no longer has a pointer to an
  TextInputController object (because there is no longer a
  central/global TextInputController object).  This means having to
  move code that calls TextInputController::Install away
  from TestInterfaces.

Additional changes:
- TextInputController does not need to inherit from
  base::SupportsWeakPtr<...> (because TextInputController already
  has a weak_factory_ field).

BUG=595089
==========

to

==========
Use correct WebView from TextInputController.

Before this CL TextInputController would act on the WebView
associated with the main test window, rather than acting on the WebView
associated with the frame owning the TextInputController's
javascript bindings.  This could potentially lead to UaF
(there is no known repro though at the moment).

Changes in the current CL:
- TextInputController's lifetime is now owned by WebViewTestProxy
  (rather than having TextInputController owned by the global
  TestInterfaces object).
- TextInputController now uses WebView from the correct
  WebViewTestProxy (rather than one associted with the main test window).
- TestInterfaces object no longer has a pointer to an
  TextInputController object (because there is no longer a
  central/global TextInputController object).  This means having to
  move code that calls TextInputController::Install away
  from TestInterfaces.

Additional changes:
- TextInputController does not need to inherit from
  base::SupportsWeakPtr<...> (because TextInputController already
  has a weak_factory_ field).

BUG=595089

Committed: https://crrev.com/8b6d5f3c021f312bb13f4a4cf2c04bd8f1c5187f
Cr-Commit-Position: refs/heads/master@{#389142}
==========

[commit-bot: I haz the power, 2016-04-22 19:48:52]

Patchset 4 (id:??) landed as
https://crrev.com/8b6d5f3c021f312bb13f4a4cf2c04bd8f1c5187f
Cr-Commit-Position: refs/heads/master@{#389142}