Use correct WebView from EventSender.

Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests
can use to inject input events (i.e. mouse events) into WebView.  Before
this CL EventSender would act on the WebView associated with the main
test window, rather than acting on the WebView associated with the frame
owning the javascript bindings.  This could lead to UaF - i.e. when
EventSender::PointerDown tries to access an already destroyed WebView
(no good repro at ToT - repro would happen after other OOPIF
refactorings when running in --site-per-process mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089
Committed: https://crrev.com/335bb76db170d76ba46fa003a8838255a5d46187
Cr-Commit-Position: refs/heads/master@{#389139}

[Łukasz Anforowicz, 2016-04-20 21:40:49]

Description was changed from

==========
Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests can use
to inject input events (i.e. mouse events) into WebView.  Before this CL
EventSender would act on the WebView associated with the main test window,
rather than acting on the WebView associated with the frame owning the
javascript bindings.  This could lead to UaF (no good repro at ToT - repro
would happen after other OOPIF refactorings when running in --site-per-process
mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089
==========

to

==========
Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests
can use to inject input events (i.e. mouse events) into WebView.  Before
this CL EventSender would act on the WebView associated with the main
test window, rather than acting on the WebView associated with the frame
owning the javascript bindings.  This could lead to UaF - i.e. when
EventSender::PointerDown tries to access an already destroyed WebView
(no good repro at ToT - repro would happen after other OOPIF
refactorings when running in --site-per-process mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089
==========

[Łukasz Anforowicz, 2016-04-21 23:01:45]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-04-21 23:01:45]

jochen@, could you please take a look?

https://codereview.chromium.org/1897363003/diff/80001/components/test_runner/...
File components/test_runner/event_sender.cc (left):

https://codereview.chromium.org/1897363003/diff/80001/components/test_runner/...
components/test_runner/event_sender.cc:1223: click_count_(0),
All of the removed initializers above are already handled by Reset below.

Fun fact: force_layout_on_events_ was initialized to false above, but to true in
Reset method.  I've spent 2 hours today figuring out that this was the cause of
a test failure (well, one other cause is that after my other changes Reset is no
longer called before the first test, only in-between tests;  I think this is
reasonable and that in any case difference between constructor and Reset was
wrong).

[Łukasz Anforowicz, 2016-04-21 23:03:23]

Description was changed from

==========
Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests
can use to inject input events (i.e. mouse events) into WebView.  Before
this CL EventSender would act on the WebView associated with the main
test window, rather than acting on the WebView associated with the frame
owning the javascript bindings.  This could lead to UaF - i.e. when
EventSender::PointerDown tries to access an already destroyed WebView
(no good repro at ToT - repro would happen after other OOPIF
refactorings when running in --site-per-process mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089
==========

to

==========
Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests
can use to inject input events (i.e. mouse events) into WebView.  Before
this CL EventSender would act on the WebView associated with the main
test window, rather than acting on the WebView associated with the frame
owning the javascript bindings.  This could lead to UaF - i.e. when
EventSender::PointerDown tries to access an already destroyed WebView
(no good repro at ToT - repro would happen after other OOPIF
refactorings when running in --site-per-process mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089
==========

[jochen (gone - plz use gerrit), 2016-04-22 15:24:51]

lgtm

[Łukasz Anforowicz, 2016-04-22 16:05:26]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-04-22 16:05:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1897363003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1897363003/80001

[commit-bot: I haz the power, 2016-04-22 16:44:14]

Description was changed from

==========
Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests
can use to inject input events (i.e. mouse events) into WebView.  Before
this CL EventSender would act on the WebView associated with the main
test window, rather than acting on the WebView associated with the frame
owning the javascript bindings.  This could lead to UaF - i.e. when
EventSender::PointerDown tries to access an already destroyed WebView
(no good repro at ToT - repro would happen after other OOPIF
refactorings when running in --site-per-process mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089
==========

to

==========
Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests
can use to inject input events (i.e. mouse events) into WebView.  Before
this CL EventSender would act on the WebView associated with the main
test window, rather than acting on the WebView associated with the frame
owning the javascript bindings.  This could lead to UaF - i.e. when
EventSender::PointerDown tries to access an already destroyed WebView
(no good repro at ToT - repro would happen after other OOPIF
refactorings when running in --site-per-process mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089
==========

[commit-bot: I haz the power, 2016-04-22 16:44:16]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 19:48:45]

Description was changed from

==========
Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests
can use to inject input events (i.e. mouse events) into WebView.  Before
this CL EventSender would act on the WebView associated with the main
test window, rather than acting on the WebView associated with the frame
owning the javascript bindings.  This could lead to UaF - i.e. when
EventSender::PointerDown tries to access an already destroyed WebView
(no good repro at ToT - repro would happen after other OOPIF
refactorings when running in --site-per-process mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089
==========

to

==========
Use correct WebView from EventSender.

EventSender provides javascript bindings for test functions that tests
can use to inject input events (i.e. mouse events) into WebView.  Before
this CL EventSender would act on the WebView associated with the main
test window, rather than acting on the WebView associated with the frame
owning the javascript bindings.  This could lead to UaF - i.e. when
EventSender::PointerDown tries to access an already destroyed WebView
(no good repro at ToT - repro would happen after other OOPIF
refactorings when running in --site-per-process mode).

Changes in the current CL:
- EventSender's lifetime is now owned by WebViewTestProxy (rather than
  having EventSender owned by the global TestInterfaces object).
- EventSender now uses WebView and WebTestDelegate from the correct
  WebViewTestProxy (rather than ones associted with the main test window).
- TestInterfaces object no longer has a pointer to an EventSender object
  (because there is no longer a central/global EventSender object).
  This means having to move code that calls EventSender::Install
  and EventSender::set_send_wheel_gestures away from TestInterfaces.

Additional changes:
- Some methods of EventSender can be made private
- EventSender does not need to inherit from base::SupportsWeakPtr<...>
  (because EventSender already has a weak_factory_ field).

BUG=595089

Committed: https://crrev.com/335bb76db170d76ba46fa003a8838255a5d46187
Cr-Commit-Position: refs/heads/master@{#389139}
==========

[commit-bot: I haz the power, 2016-04-22 19:48:46]

Patchset 5 (id:??) landed as
https://crrev.com/335bb76db170d76ba46fa003a8838255a5d46187
Cr-Commit-Position: refs/heads/master@{#389139}