Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Unified Diff: components/test_runner/test_interfaces.cc

Issue 1896413003: Use correct WebView from TextInputController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event-sender-per-view
Patch Set: Rebasing... Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/test_interfaces.h ('k') | components/test_runner/text_input_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/test_interfaces.cc
diff --git a/components/test_runner/test_interfaces.cc b/components/test_runner/test_interfaces.cc
index c405f477facb83b38d52217ede56d7ed7d7bae6b..a45e02e086219904654607f284f3eca9b42bfe17 100644
--- a/components/test_runner/test_interfaces.cc
+++ b/components/test_runner/test_interfaces.cc
@@ -29,7 +29,6 @@ namespace test_runner {
TestInterfaces::TestInterfaces()
: accessibility_controller_(new AccessibilityController()),
- text_input_controller_(new TextInputController()),
test_runner_(new TestRunner(this)),
delegate_(nullptr),
app_banner_client_(nullptr) {
@@ -43,12 +42,10 @@ TestInterfaces::TestInterfaces()
TestInterfaces::~TestInterfaces() {
accessibility_controller_->SetWebView(nullptr);
// gamepad_controller_ doesn't depend on WebView.
- text_input_controller_->SetWebView(nullptr);
test_runner_->SetWebView(nullptr);
accessibility_controller_->SetDelegate(nullptr);
// gamepad_controller_ ignores SetDelegate(nullptr)
- // text_input_controller_ doesn't depend on WebTestDelegate.
test_runner_->SetDelegate(nullptr);
}
@@ -56,14 +53,12 @@ void TestInterfaces::SetWebView(blink::WebView* web_view,
WebTestProxyBase* proxy) {
accessibility_controller_->SetWebView(web_view);
// gamepad_controller_ doesn't depend on WebView.
- text_input_controller_->SetWebView(web_view);
test_runner_->SetWebView(web_view);
}
void TestInterfaces::SetDelegate(WebTestDelegate* delegate) {
accessibility_controller_->SetDelegate(delegate);
gamepad_controller_ = GamepadController::Create(delegate);
- // text_input_controller_ doesn't depend on WebTestDelegate.
test_runner_->SetDelegate(delegate);
delegate_ = delegate;
}
@@ -72,7 +67,6 @@ void TestInterfaces::BindTo(blink::WebFrame* frame) {
accessibility_controller_->Install(frame);
if (gamepad_controller_)
gamepad_controller_->Install(frame);
- text_input_controller_->Install(frame);
test_runner_->Install(frame);
GCController::Install(frame);
}
@@ -81,7 +75,6 @@ void TestInterfaces::ResetTestHelperControllers() {
accessibility_controller_->Reset();
if (gamepad_controller_)
gamepad_controller_->Reset();
- // text_input_controller_ doesn't have any state to reset.
blink::WebCache::clear();
for (WebTestProxyBase* web_test_proxy_base : window_list_)
« no previous file with comments | « components/test_runner/test_interfaces.h ('k') | components/test_runner/text_input_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698