Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1895763002: [compiler] Remove obsolete CompileUnoptimizedCode helper. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-simplify-16
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove obsolete CompileUnoptimizedCode helper. This removes the helper function in question that side-steps the interpreter without going through the canonical UseIgnition predicate. Having such a function is dangerous as it hides paths that are not yet covered by the interpreter (like live edit in this case). R=yangguo@chromium.org Committed: https://crrev.com/31e46446826da55c4fed8745122f835b3bc0b21e Cr-Commit-Position: refs/heads/master@{#35580}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M src/compiler.cc View 3 chunks +10 lines, -11 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-18 12:07:20 UTC) #3
Yang
lgtm
4 years, 8 months ago (2016-04-18 12:17:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895763002/1
4 years, 8 months ago (2016-04-18 13:04:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 13:06:57 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 13:07:33 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31e46446826da55c4fed8745122f835b3bc0b21e
Cr-Commit-Position: refs/heads/master@{#35580}

Powered by Google App Engine
This is Rietveld 408576698