Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1895033003: [compiler] Introduce common structure to compile methods. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-simplify-17
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Introduce common structure to compile methods. This should be a plain refactoring change with only negligible changes to method semantics. The main aim is to improve readability of some API method implementations. R=mvstanton@chromium.org Committed: https://crrev.com/e9dfcf4f0c611e48c35417af92cdcfe4b379a9e5 Cr-Commit-Position: refs/heads/master@{#35583}

Patch Set 1 #

Patch Set 2 : Unused var. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -58 lines) Patch
M src/compiler.cc View 1 4 chunks +84 lines, -58 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-18 13:31:36 UTC) #1
mvstanton
lgtm
4 years, 8 months ago (2016-04-18 13:54:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895033003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895033003/20001
4 years, 8 months ago (2016-04-18 14:10:13 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 14:11:50 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 14:13:37 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9dfcf4f0c611e48c35417af92cdcfe4b379a9e5
Cr-Commit-Position: refs/heads/master@{#35583}

Powered by Google App Engine
This is Rietveld 408576698