Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1897793002: [compiler] Simplify Compiler::CompileDebugCode a bit. (Closed)

Created:
4 years, 8 months ago by Michael Starzinger
Modified:
4 years, 8 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Simplify Compiler::CompileDebugCode a bit. R=yangguo@chromium.org Committed: https://crrev.com/e2ff7d121d9c22a7dd4c8f10a9fc52823b7ec848 Cr-Commit-Position: refs/heads/master@{#35579}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M src/compiler.cc View 1 chunk +7 lines, -18 lines 0 comments Download

Dependent Patchsets:

Issue 1895763002 Patch 1

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 8 months ago (2016-04-18 11:40:40 UTC) #3
Yang
On 2016/04/18 11:40:40, Michael Starzinger wrote: lgtm.
4 years, 8 months ago (2016-04-18 12:52:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1897793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1897793002/1
4 years, 8 months ago (2016-04-18 12:56:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 12:58:16 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 12:59:35 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e2ff7d121d9c22a7dd4c8f10a9fc52823b7ec848
Cr-Commit-Position: refs/heads/master@{#35579}

Powered by Google App Engine
This is Rietveld 408576698