Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve FocusController handling of RemoteFrames Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8WindowShell.cpp
diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp
index 17e19be2a8dcf1e1a94c412dbe2a4eec65163c99..25a298c1bd0a775cc46eb625a929d9be92f7e40c 100644
--- a/Source/bindings/v8/V8WindowShell.cpp
+++ b/Source/bindings/v8/V8WindowShell.cpp
@@ -432,7 +432,7 @@ static v8::Handle<v8::Value> getNamedProperty(HTMLDocument* htmlDocument, const
if (items->hasExactlyOneItem()) {
Element* element = items->item(0);
LocalFrame* frame = 0;
- if (element->hasTagName(HTMLNames::iframeTag) && (frame = toHTMLIFrameElement(element)->contentFrame()))
+ if (element->hasTagName(HTMLNames::iframeTag) && (frame = toLocalFrame(toHTMLIFrameElement(element)->contentFrame())))
eseidel 2014/03/07 22:42:53 Confused. This isn't always true, is it? Shouldn
kenrb 2014/03/07 23:56:45 Sorry about that, I had added a bunch of checks bu
return toV8(frame->domWindow(), creationContext, isolate);
return toV8(element, creationContext, isolate);
}
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698