Convert HTMLFrameOwnerElement and FocusController to use Frame.

Source/bindings/v8/V8WindowShell.cpp

 /*
  * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 414 matching lines @@
     if (!htmlDocument->hasNamedItem(key) && !htmlDocument->hasExtraNamedItem(key))
         return v8Undefined();
 
     RefPtr<HTMLCollection> items = htmlDocument->documentNamedItems(key);
     if (items->isEmpty())
         return v8Undefined();
 
     if (items->hasExactlyOneItem()) {
         Element* element = items->item(0);
         LocalFrame* frame = 0;
-        if (element->hasTagName(HTMLNames::iframeTag) && (frame = toHTMLIFrameElement(element)->contentFrame()))
+        if (element->hasTagName(HTMLNames::iframeTag) && (frame = toLocalFrame(toHTMLIFrameElement(element)->contentFrame())))

[eseidel, 2014/03/07 22:42:53]

Confused.  This isn't always true, is it?  Shouldn't we check to see that the
iframe has a real local frame?  I presumed that would be the point of using the
compiler to do this, that it would force us to audit all callers?

[kenrb, 2014/03/07 23:56:45]

Sorry about that, I had added a bunch of checks but they were on the wrong
branch.

In general, my intent was to just use toLocalFrame() on code paths where we
should only get LocalFrames, and do a check on paths where we might have to
handle both. toLocalFrame() contains an implicit assertion that we are right.
Unfortunately we aren't far enough along to instantiate a RemoteFrame and test
to see which asserts fire.

Also, in the places where we check isLocalFrame() but have to handle both types,
the correct behavior for RemoteFrames is not always obvious.

             return toV8(frame->domWindow(), creationContext, isolate);
         return toV8(element, creationContext, isolate);
     }
     return toV8(items.release(), creationContext, isolate);
 }
 
 static void getter(v8::Local<v8::String> property, const v8::PropertyCallbackInfo<v8::Value>& info)
 {
     // FIXME: Consider passing StringImpl directly.
     AtomicString name = toCoreAtomicString(property);
@@ skipping 60 matching lines @@
     if (!isMainThread())
         return true;
     // We're initializing the context, so it is not yet in a status where we can
     // validate the context.
     if (contextBeingInitialized)
         return true;
     return !!toDOMWindow(context);
 }
 
 } // WebCore