Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp

Issue 189573002: Convert HTMLFrameOwnerElement and FocusController to use Frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve FocusController handling of RemoteFrames Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp
index c9e108b54a5fbd38d36546a1f45ae6cca96a71e7..d6eda71d0357ae284e62a4bb57eef09d25e907e5 100644
--- a/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp
+++ b/Source/bindings/v8/custom/V8HTMLFrameElementCustom.cpp
@@ -35,6 +35,7 @@
#include "bindings/v8/BindingSecurity.h"
#include "bindings/v8/ExceptionState.h"
#include "bindings/v8/V8Binding.h"
+#include "core/frame/LocalFrame.h"
#include "core/html/HTMLFrameElement.h"
#include "core/html/parser/HTMLParserIdioms.h"
@@ -48,7 +49,7 @@ void V8HTMLFrameElement::locationAttributeSetterCustom(v8::Local<v8::Value> valu
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<WithNullCheck>, locationValue, value);
ExceptionState exceptionState(ExceptionState::SetterContext, "location", "HTMLFrameElement", info.Holder(), info.GetIsolate());
- if (protocolIsJavaScript(stripLeadingAndTrailingHTMLSpaces(locationValue)) && !BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), frame->contentFrame(), exceptionState)) {
+ if (protocolIsJavaScript(stripLeadingAndTrailingHTMLSpaces(locationValue)) && !BindingSecurity::shouldAllowAccessToFrame(info.GetIsolate(), toLocalFrame(frame->contentFrame()), exceptionState)) {
exceptionState.throwIfNeeded();
return;
}

Powered by Google App Engine
This is Rietveld 408576698