[Fetch API] Add streams predicates to BodyStreamBuffer

[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL doesn't change the behavior.

BUG=596832
Committed: https://crrev.com/8afb8bb77edb8c33d5f9aeb8741e31bc7474a0ad
Cr-Commit-Position: refs/heads/master@{#388180}

[yhirano, 2016-04-19 07:44:09]

Description was changed from

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL doesn't change the behavior.

BUG=596832
==========

to

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL also fixes when the associated stream is disturbed.
drainAs* functions should not make the stream disturbed when returning
null.

BUG=596832
==========

[yhirano, 2016-04-19 07:44:41]

Description was changed from

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL also fixes when the associated stream is disturbed.
drainAs* functions should not make the stream disturbed when returning
null.

BUG=596832
==========

to

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL also changes the condition when the stream gets disturbed.
drainAs* functions should not make the stream disturbed when returning
null.

BUG=596832
==========

[yhirano, 2016-04-19 07:45:46]

Patchset #1 (id:1) has been deleted

[yhirano, 2016-04-19 07:46:02]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org

[hiroshige, 2016-04-19 07:58:55]

> This CL also changes the condition when the stream gets disturbed.
> drainAs* functions should not make the stream disturbed when returning
> null.
Can/should we add tests for this behavior change?

https://codereview.chromium.org/1895693004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp (right):

https://codereview.chromium.org/1895693004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:57: }
We don't have |EXPECT_TRUE(buffer->isStreamClosed());| here. Is this
intentional?

[yhirano, 2016-04-19 09:16:01]

Description was changed from

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL also changes the condition when the stream gets disturbed.
drainAs* functions should not make the stream disturbed when returning
null.

BUG=596832
==========

to

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL also doesn't change the behavior.

BUG=596832
==========

[yhirano, 2016-04-19 09:22:41]

> Can/should we add tests for this behavior change?
When writing tests, I found another related bug. I would like to fix it as a
separate CL.

https://codereview.chromium.org/1895693004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp (right):

https://codereview.chromium.org/1895693004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:57: }
On 2016/04/19 07:58:55, hiroshige wrote:
> We don't have |EXPECT_TRUE(buffer->isStreamClosed());| here. Is this
> intentional?

Fixed.

[hiroshige, 2016-04-19 10:20:14]

lgtm if bots are happy.

[yhirano, 2016-04-19 10:25:27]

Description was changed from

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL also doesn't change the behavior.

BUG=596832
==========

to

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL doesn't change the behavior.

BUG=596832
==========

[yhirano, 2016-04-19 10:51:48]

The CQ bit was checked by yhirano@chromium.org

[commit-bot: I haz the power, 2016-04-19 10:51:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1895693004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1895693004/60001

[commit-bot: I haz the power, 2016-04-19 10:55:39]

Description was changed from

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL doesn't change the behavior.

BUG=596832
==========

to

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL doesn't change the behavior.

BUG=596832
==========

[commit-bot: I haz the power, 2016-04-19 10:55:40]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-04-19 10:57:11]

Description was changed from

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL doesn't change the behavior.

BUG=596832
==========

to

==========
[Fetch API] Add streams predicates to BodyStreamBuffer

This CL adds predicates for the body stream in BodyStreamBuffer to make it
easy to replace the stream with v8-extra based one.

This CL doesn't change the behavior.

BUG=596832

Committed: https://crrev.com/8afb8bb77edb8c33d5f9aeb8741e31bc7474a0ad
Cr-Commit-Position: refs/heads/master@{#388180}
==========

[commit-bot: I haz the power, 2016-04-19 10:57:12]

Patchset 3 (id:??) landed as
https://crrev.com/8afb8bb77edb8c33d5f9aeb8741e31bc7474a0ad
Cr-Commit-Position: refs/heads/master@{#388180}