BodyStreamBuffer's drainAs* function should lock stream

BodyStreamBuffer's drainAs* function should lock stream

BodyStreamBuffer::drainAsBlobDataHandle and BodyStreamBuffer::drainAsFormData
should lock and disturb the associated stream when returning a non-null handle.
Moreover, it should NOT lock and disturb the associated stream when returning a
null handle.

BUG=596832
Committed: https://crrev.com/b6ef89239544be60b3df1cb6c813e7a344c1fee7
Cr-Commit-Position: refs/heads/master@{#389028}

[yhirano, 2016-04-20 01:21:35]

yhirano@chromium.org changed reviewers:
+ hiroshige@chromium.org

[tyoshino (SeeGerritForStatus), 2016-04-21 06:47:42]

tyoshino@chromium.org changed reviewers:
+ tyoshino@chromium.org

[tyoshino (SeeGerritForStatus), 2016-04-21 06:47:42]

lgtm

https://codereview.chromium.org/1899163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp (right):

https://codereview.chromium.org/1899163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:96:
BodyStreamBuffer* buffer = new
BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(createWaitingDataConsumerHandle()));
add a comment here or in DataConsumerHandleUtil.h saying that
createWaitingDataConsumerHandle() is not drainable.

[yhirano, 2016-04-21 08:22:08]

yhirano@chromium.org changed reviewers:
+ horo@chromium.org

[yhirano, 2016-04-21 08:22:36]

https://codereview.chromium.org/1899163002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp (right):

https://codereview.chromium.org/1899163002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp:96:
BodyStreamBuffer* buffer = new
BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(createWaitingDataConsumerHandle()));
On 2016/04/21 06:47:42, tyoshino wrote:
> add a comment here or in DataConsumerHandleUtil.h saying that
> createWaitingDataConsumerHandle() is not drainable.

Done.

[yhirano, 2016-04-21 08:22:57]

+horo@ for modules/serviceworkers

[horo, 2016-04-22 02:00:59]

On 2016/04/21 08:22:57, yhirano wrote:
> +horo@ for modules/serviceworkers

lgtm

[horo, 2016-04-22 02:00:59]

On 2016/04/21 08:22:57, yhirano wrote:
> +horo@ for modules/serviceworkers

lgtm

[yhirano, 2016-04-22 02:03:37]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2016-04-22 02:03:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
tyoshino@chromium.org
Link to the patchset: https://codereview.chromium.org/1899163002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-22 02:03:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899163002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899163002/40001

[commit-bot: I haz the power, 2016-04-22 04:12:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-22 19:44:22]

Description was changed from

==========
BodyStreamBuffer's drainAs* function should lock stream

BodyStreamBuffer::drainAsBlobDataHandle and BodyStreamBuffer::drainAsFormData
should lock and disturb the associated stream when returning a non-null handle.
Moreover, it should NOT lock and disturb the associated stream when returning a
null handle.

BUG=596832
==========

to

==========
BodyStreamBuffer's drainAs* function should lock stream

BodyStreamBuffer::drainAsBlobDataHandle and BodyStreamBuffer::drainAsFormData
should lock and disturb the associated stream when returning a non-null handle.
Moreover, it should NOT lock and disturb the associated stream when returning a
null handle.

BUG=596832

Committed: https://crrev.com/b6ef89239544be60b3df1cb6c813e7a344c1fee7
Cr-Commit-Position: refs/heads/master@{#389028}
==========

[commit-bot: I haz the power, 2016-04-22 19:44:23]

Patchset 3 (id:??) landed as
https://crrev.com/b6ef89239544be60b3df1cb6c813e7a344c1fee7
Cr-Commit-Position: refs/heads/master@{#389028}