Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp

Issue 1895693004: [Fetch API] Add streams predicates to BodyStreamBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
index 7e2117973262604b435f2e36a1b94f344ce71c21..0880c42a4e4a2bcf7277af75a01deae7be8da739 100644
--- a/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
+++ b/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
@@ -84,9 +84,9 @@ BodyStreamBuffer::BodyStreamBuffer(PassOwnPtr<FetchDataConsumerHandle> handle)
PassRefPtr<BlobDataHandle> BodyStreamBuffer::drainAsBlobDataHandle(FetchDataConsumerHandle::Reader::BlobSizePolicy policy)
{
- ASSERT(!stream()->isLocked());
+ ASSERT(!isStreamLocked());
m_stream->setIsDisturbed();
- if (ReadableStream::Closed == m_stream->stateInternal() || ReadableStream::Errored == m_stream->stateInternal())
+ if (isStreamClosed() || isStreamErrored())
return nullptr;
RefPtr<BlobDataHandle> blobDataHandle = m_reader->drainAsBlobDataHandle(policy);
@@ -99,9 +99,9 @@ PassRefPtr<BlobDataHandle> BodyStreamBuffer::drainAsBlobDataHandle(FetchDataCons
PassRefPtr<EncodedFormData> BodyStreamBuffer::drainAsFormData()
{
- ASSERT(!stream()->isLocked());
+ ASSERT(!isStreamLocked());
m_stream->setIsDisturbed();
- if (ReadableStream::Closed == m_stream->stateInternal() || ReadableStream::Errored == m_stream->stateInternal())
+ if (isStreamClosed() || isStreamErrored())
return nullptr;
RefPtr<EncodedFormData> formData = m_reader->drainAsFormData();
@@ -114,15 +114,15 @@ PassRefPtr<EncodedFormData> BodyStreamBuffer::drainAsFormData()
PassOwnPtr<FetchDataConsumerHandle> BodyStreamBuffer::releaseHandle(ExecutionContext* executionContext)
{
- ASSERT(!stream()->isLocked());
+ ASSERT(!isStreamLocked());
m_reader = nullptr;
m_stream->setIsDisturbed();
TrackExceptionState exceptionState;
m_stream->getBytesReader(executionContext, exceptionState);
- if (ReadableStream::Closed == m_stream->stateInternal())
+ if (isStreamClosed())
return createFetchDataConsumerHandleFromWebHandle(createDoneDataConsumerHandle());
- if (ReadableStream::Errored == m_stream->stateInternal())
+ if (isStreamErrored())
return createFetchDataConsumerHandleFromWebHandle(createUnexpectedErrorDataConsumerHandle());
ASSERT(m_handle);
@@ -141,7 +141,7 @@ void BodyStreamBuffer::startLoading(ExecutionContext* executionContext, FetchDat
bool BodyStreamBuffer::hasPendingActivity() const
{
- return m_loader || (m_stream->isLocked() && m_stream->stateInternal() == ReadableStream::Readable);
+ return m_loader || (isStreamLocked() && isStreamReadable());
}
void BodyStreamBuffer::stop()
@@ -190,6 +190,31 @@ void BodyStreamBuffer::didGetReadable()
processData();
}
+bool BodyStreamBuffer::isStreamReadable() const
+{
+ return m_stream->stateInternal() == ReadableStream::Readable;
+}
+
+bool BodyStreamBuffer::isStreamClosed() const
+{
+ return m_stream->stateInternal() == ReadableStream::Closed;
+}
+
+bool BodyStreamBuffer::isStreamErrored() const
+{
+ return m_stream->stateInternal() == ReadableStream::Errored;
+}
+
+bool BodyStreamBuffer::isStreamLocked() const
+{
+ return m_stream->isLocked();
+}
+
+bool BodyStreamBuffer::isStreamDisturbed() const
+{
+ return m_stream->isDisturbed();
+}
+
void BodyStreamBuffer::close()
{
m_reader = nullptr;

Powered by Google App Engine
This is Rietveld 408576698