Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1895453002: [build] Tweak configuration for win-clang (Closed)

Created:
4 years, 8 months ago by Michael Achenbach
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Tweak configuration for win-clang Unports parts of https://codereview.chromium.org/1828543003 as per suggestion in https://codereview.chromium.org/1886293002/ Ports https://codereview.chromium.org/1532723003 Also restores -fmsc-version=1800 to support win-clang with MSVS 2013. BUG=chromium:603011 LOG=n NOTRY=true Committed: https://crrev.com/6ef4bd8aa72899ad73e4a84241f8e54ceb60c7ad Cr-Commit-Position: refs/heads/master@{#35535}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -1 line) Patch
A build/set_clang_warning_flags.gypi View 1 1 chunk +59 lines, -0 lines 0 comments Download
M build/standalone.gypi View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895453002/1
4 years, 8 months ago (2016-04-15 13:33:57 UTC) #3
Michael Achenbach
PTAL
4 years, 8 months ago (2016-04-15 13:45:53 UTC) #5
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/1895453002/diff/1/build/set_clang_warning_flags.gypi File build/set_clang_warning_flags.gypi (right): https://codereview.chromium.org/1895453002/diff/1/build/set_clang_warning_flags.gypi#newcode1 build/set_clang_warning_flags.gypi:1: # Copyright 2015 the V8 project authors. All ...
4 years, 8 months ago (2016-04-15 13:48:48 UTC) #6
Michael Achenbach
https://codereview.chromium.org/1895453002/diff/1/build/set_clang_warning_flags.gypi File build/set_clang_warning_flags.gypi (right): https://codereview.chromium.org/1895453002/diff/1/build/set_clang_warning_flags.gypi#newcode1 build/set_clang_warning_flags.gypi:1: # Copyright 2015 the V8 project authors. All rights ...
4 years, 8 months ago (2016-04-15 13:51:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1895453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1895453002/20001
4 years, 8 months ago (2016-04-15 13:51:34 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-15 13:56:41 UTC) #13
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 13:58:24 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6ef4bd8aa72899ad73e4a84241f8e54ceb60c7ad
Cr-Commit-Position: refs/heads/master@{#35535}

Powered by Google App Engine
This is Rietveld 408576698