Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1828543003: clang/win: Stop passing -Qunused-arguments. (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 8 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Stop passing -Qunused-arguments. All flags except /GS and /GL are accepted by clang-cl by now. To be able to turn on -Qunused-arguments, don't pass /GS and /GL in clang builds for now. BUG=504658, 598772, 598767 NOTRY=true Committed: https://crrev.com/de51a84b69b5b1dd458c65f6aaf2335f81b57785 Cr-Commit-Position: refs/heads/master@{#383954} R=hans@chromium.org Committed: https://crrev.com/cb19a4e78e9c472914680235c75f2b9afe554b20 Cr-Commit-Position: refs/heads/master@{#384004}

Patch Set 1 #

Patch Set 2 : no -qunused-arg #

Patch Set 3 : rebase #

Patch Set 4 : . #

Patch Set 5 : rebase #

Patch Set 6 : try to fix official #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M build/common.gypi View 1 2 3 4 5 4 chunks +19 lines, -4 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M build/config/win/BUILD.gn View 1 2 3 5 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 23 (12 generated)
Nico
assuming the trybots come back green…
4 years, 8 months ago (2016-03-29 21:46:28 UTC) #4
hans
lgtm with green bots
4 years, 8 months ago (2016-03-29 21:51:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828543003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828543003/80001
4 years, 8 months ago (2016-03-30 02:38:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/124073)
4 years, 8 months ago (2016-03-30 08:39:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828543003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828543003/80001
4 years, 8 months ago (2016-03-30 12:25:48 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-03-30 12:30:22 UTC) #14
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/de51a84b69b5b1dd458c65f6aaf2335f81b57785 Cr-Commit-Position: refs/heads/master@{#383954}
4 years, 8 months ago (2016-03-30 12:32:26 UTC) #16
Nico
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1838903008/ by thakis@chromium.org. ...
4 years, 8 months ago (2016-03-30 13:05:15 UTC) #17
Nico
Committed patchset #6 (id:100001) to pending queue manually as 8fdeaf74378c1d57a080c8134f5760b631b34daa (presubmit successful).
4 years, 8 months ago (2016-03-30 16:50:18 UTC) #20
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/cb19a4e78e9c472914680235c75f2b9afe554b20 Cr-Commit-Position: refs/heads/master@{#384004}
4 years, 8 months ago (2016-03-30 16:51:26 UTC) #22
Nico
4 years, 8 months ago (2016-03-30 18:37:20 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1846633004/ by thakis@chromium.org.

The reason for reverting is: Speculative; official builds mysteriously exploded
(crbug.com/599186) and this is on the blame list....

Powered by Google App Engine
This is Rietveld 408576698