Issue 1532723003: Make clang_warning_flags work for standalone builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1532723003: Make clang_warning_flags work for standalone builds. (Closed)

Created:
5 years ago by Lei Zhang

Modified:
5 years ago

Reviewers:
Nico

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make clang_warning_flags work for standalone builds. Also fix a newly introduced override warning. R=thakis@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e096ca507db9944aebc47d6c2cc1c6fab39498c5

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -2 lines)			Patch
A	build/set_clang_warning_flags.gypi	View	1 chunk	+58 lines, -0 lines	0 comments	Download
M	build/standalone.gypi	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Lei Zhang

5 years ago (2015-12-17 02:37:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e096ca507db9944aebc47d6c2cc1c6fab39498c5 (presubmit successful).