Ensure proper finalization of garbage-collected types.

Source/heap/HeapTest.cpp

Index: Source/heap/HeapTest.cpp
diff --git a/Source/heap/HeapTest.cpp b/Source/heap/HeapTest.cpp
index 7b2ec530ab61592f54946ac12e48c23f0385ff62..03d9115db4d191577d6aa37ce2290663df8de691 100644
--- a/Source/heap/HeapTest.cpp
+++ b/Source/heap/HeapTest.cpp
@@ -977,6 +977,20 @@ private:
     Member<SimpleFinalizedObject> m_value;
 };
 
+} // WebCore namespace
+
+namespace WTF {

[Mads Ager (chromium), 2014/03/11 13:34:41]

Why do you need to move this Ian?

[zerny-chromium, 2014/03/11 13:54:12]

The below code uses inlineCapacity for a vector of VectorObject. Since
VectorTraits<VectorObject>::needsDestruction now determines the
VectorDestructionBase it must be known at that point. This is only required for
heap allocated vectors with inline capacity, which really means that the
VectorObject is to be seen as a part object too. So no circularity should be
able to occur in any case. (This is not always the case and the reason we need
the extra base class to delay our inspection of needsDestruction.)

[Mads Ager (chromium), 2014/03/11 15:09:20]

Ah, yes, thanks for the explanation. :)

+
+// We need the below vector trait specialization for the above HeapVectors to behave correctly wrt. memset, memcmp etc.
+template<> struct VectorTraits<WebCore::VectorObject> : public SimpleClassVectorTraits<WebCore::VectorObject> { };
+template<> struct VectorTraits<WebCore::VectorObjectInheritedTrace> : public SimpleClassVectorTraits<WebCore::VectorObjectInheritedTrace> { };
+template<> struct VectorTraits<WebCore::VectorObjectNoTrace> : public SimpleClassVectorTraits<WebCore::VectorObjectNoTrace> { };
+
+} // WTF namespace
+
+namespace WebCore {
+
+
 TEST(HeapTest, Transition)
 {
     {
@@ -2620,13 +2634,3 @@ TEST(HeapTest, RawPtrInHash)
 }
 
 } // WebCore namespace
-
-namespace WTF {
-
-// We need the below vector trait specialization for the above HeapVectors to behave correctly wrt. memset, memcmp etc.
-template<> struct VectorTraits<WebCore::VectorObject> : public SimpleClassVectorTraits<WebCore::VectorObject> { };
-template<> struct VectorTraits<WebCore::VectorObjectInheritedTrace> : public SimpleClassVectorTraits<WebCore::VectorObjectInheritedTrace> { };
-template<> struct VectorTraits<WebCore::VectorObjectNoTrace> : public SimpleClassVectorTraits<WebCore::VectorObjectNoTrace> { };
-
-} // WTF namespace
-