Source/core/plugins/DOMPluginArray.h - Issue 189543014: Ensure proper finalization of garbage-collected types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/plugins/DOMPluginArray.h

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: finalize HashTable Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/plugins/DOMPluginArray.h

diff --git a/Source/core/plugins/DOMPluginArray.h b/Source/core/plugins/DOMPluginArray.h

index c73d7e6da234e8361ae5ed5e7848f5d2b3a53df5..1834cc36da5e96f03de116384cb5f8698c767e75 100644

--- a/Source/core/plugins/DOMPluginArray.h

+++ b/Source/core/plugins/DOMPluginArray.h

@@ -35,7 +35,7 @@ namespace WebCore {

class LocalFrame;

class PluginData;

-class DOMPluginArray FINAL : public RefCountedWillBeGarbageCollected<DOMPluginArray>, public ScriptWrappable, public DOMWindowProperty {

+class DOMPluginArray FINAL : public RefCountedWillBeGarbageCollectedFinalized<DOMPluginArray>, public ScriptWrappable, public DOMWindowProperty {

Mads Ager (chromium) 2014/03/11 13:34:41 This is the benefit of this. Here is a script wrap

public:

static PassRefPtrWillBeRawPtr<DOMPluginArray> create(LocalFrame* frame)

{