Ensure proper finalization of garbage-collected types.

Source/heap/HeapTest.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 959 matching lines @@
 public:
     VectorObjectNoTrace()
     {
         m_value = SimpleFinalizedObject::create();
     }
 
 private:
     Member<SimpleFinalizedObject> m_value;
 };
 
+} // WebCore namespace
+
+namespace WTF {

[Mads Ager (chromium), 2014/03/11 13:34:41]

Why do you need to move this Ian?

[zerny-chromium, 2014/03/11 13:54:12]

The below code uses inlineCapacity for a vector of VectorObject. Since
VectorTraits<VectorObject>::needsDestruction now determines the
VectorDestructionBase it must be known at that point. This is only required for
heap allocated vectors with inline capacity, which really means that the
VectorObject is to be seen as a part object too. So no circularity should be
able to occur in any case. (This is not always the case and the reason we need
the extra base class to delay our inspection of needsDestruction.)

[Mads Ager (chromium), 2014/03/11 15:09:20]

Ah, yes, thanks for the explanation. :)

+
+// We need the below vector trait specialization for the above HeapVectors to behave correctly wrt. memset, memcmp etc.
+template<> struct VectorTraits<WebCore::VectorObject> : public SimpleClassVectorTraits<WebCore::VectorObject> { };
+template<> struct VectorTraits<WebCore::VectorObjectInheritedTrace> : public SimpleClassVectorTraits<WebCore::VectorObjectInheritedTrace> { };
+template<> struct VectorTraits<WebCore::VectorObjectNoTrace> : public SimpleClassVectorTraits<WebCore::VectorObjectNoTrace> { };
+
+} // WTF namespace
+
+namespace WebCore {
+
+
 TEST(HeapTest, Transition)
 {
     {
         RefPtr<TransitionRefCounted> refCounted = TransitionRefCounted::create();
         EXPECT_EQ(1, TransitionRefCounted::s_aliveCount);
         Heap::collectGarbage(ThreadState::NoHeapPointersOnStack);
         EXPECT_EQ(1, TransitionRefCounted::s_aliveCount);
     }
     Heap::collectGarbage(ThreadState::NoHeapPointersOnStack);
     EXPECT_EQ(0, TransitionRefCounted::s_aliveCount);
@@ skipping 1623 matching lines @@
 {
     HashSet<RawPtr<int> > set;
     set.add(new int(42));
     set.add(new int(42));
     EXPECT_EQ(2u, set.size());
     for (HashSet<RawPtr<int> >::iterator it = set.begin(); it != set.end(); ++it)
         EXPECT_EQ(42, **it);
 }
 
 } // WebCore namespace
-
-namespace WTF {
-
-// We need the below vector trait specialization for the above HeapVectors to behave correctly wrt. memset, memcmp etc.
-template<> struct VectorTraits<WebCore::VectorObject> : public SimpleClassVectorTraits<WebCore::VectorObject> { };
-template<> struct VectorTraits<WebCore::VectorObjectInheritedTrace> : public SimpleClassVectorTraits<WebCore::VectorObjectInheritedTrace> { };
-template<> struct VectorTraits<WebCore::VectorObjectNoTrace> : public SimpleClassVectorTraits<WebCore::VectorObjectNoTrace> { };
-
-} // WTF namespace
-