Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: Source/core/css/CSSCalculationValue.h

Issue 189543014: Ensure proper finalization of garbage-collected types. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: finalize HashTable Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/CSSCalculationValue.h
diff --git a/Source/core/css/CSSCalculationValue.h b/Source/core/css/CSSCalculationValue.h
index ca4c5bfd24818561f43f06a899103a523a8bfd8d..b4c581ad0a6dda7899b51e4dc6d97386cf60823d 100644
--- a/Source/core/css/CSSCalculationValue.h
+++ b/Source/core/css/CSSCalculationValue.h
@@ -56,7 +56,7 @@ enum CalculationCategory {
CalcOther
};
-class CSSCalcExpressionNode : public RefCountedWillBeGarbageCollected<CSSCalcExpressionNode> {
+class CSSCalcExpressionNode : public RefCountedWillBeGarbageCollectedFinalized<CSSCalcExpressionNode> {
haraken 2014/03/11 10:26:37 Why does this class need to be GarbageCollectedFin
zerny-chromium 2014/03/11 11:05:25 Because it has a virtual destructor.
Mads Ager (chromium) 2014/03/11 13:34:41 The virtual destructor is definitely needed when !
zerny-chromium 2014/03/11 13:54:12 Will do.
public:
enum Type {
CssCalcPrimitiveValue = 1,

Powered by Google App Engine
This is Rietveld 408576698