Ensure proper finalization of garbage-collected types.

Source/core/css/CSSCalculationValue.h

 /*
  * Copyright (C) 2011, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 38 matching lines @@
 
 enum CalculationCategory {
     CalcNumber = 0,
     CalcLength,
     CalcPercent,
     CalcPercentNumber,
     CalcPercentLength,
     CalcOther
 };
 
-class CSSCalcExpressionNode : public RefCountedWillBeGarbageCollected<CSSCalcExpressionNode> {
+class CSSCalcExpressionNode : public RefCountedWillBeGarbageCollectedFinalized<CSSCalcExpressionNode> {

[haraken, 2014/03/11 10:26:37]

Why does this class need to be GarbageCollectedFinalized?

[zerny-chromium, 2014/03/11 11:05:25]

Because it has a virtual destructor.

[Mads Ager (chromium), 2014/03/11 13:34:41]

The virtual destructor is definitely needed when !ENABLE(OILPAN), however, maybe
we should ifdef it out for the ENABLE(OILPAN) build and leave this 
GarbageCollected? As far as I can tell no destructor call is needed here with
Oilpan.

[zerny-chromium, 2014/03/11 13:54:12]

Will do.

 public:
     enum Type {
         CssCalcPrimitiveValue = 1,
         CssCalcBinaryOperation
     };
 
     virtual ~CSSCalcExpressionNode() = 0;
     virtual bool isZero() const = 0;
     virtual PassOwnPtr<CalcExpressionNode> toCalcValue(const CSSToLengthConversionData&) const = 0;
     virtual double doubleValue() const = 0;
@@ skipping 66 matching lines @@
     const RefPtrWillBeMember<CSSCalcExpressionNode> m_expression;
     const bool m_nonNegative;
 };
 
 DEFINE_CSS_VALUE_TYPE_CASTS(CSSCalcValue, isCalcValue());
 
 } // namespace WebCore
 
 
 #endif // CSSCalculationValue_h