Source/core/dom/Element.h - Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Element.h

Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add performance tests about rare attribute. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Element.h

diff --git a/Source/core/dom/Element.h b/Source/core/dom/Element.h

index ba609f48cc7048c69df023eee089499db30d6c10..e895b1def0d3be0cba07d9e1d7ddc7a0f0da9d75 100644

--- a/Source/core/dom/Element.h

+++ b/Source/core/dom/Element.h

@@ -132,6 +132,9 @@ public:

bool hasAttribute(const AtomicString& name) const;

bool hasAttributeNS(const AtomicString& namespaceURI, const AtomicString& localName) const;

+ const AtomicString& bindingsGetAttribute(const String& name) const;

+ void bindingsSetAttribute(const String& name, const AtomicString& value, ExceptionState&);

const AtomicString& getAttribute(const AtomicString& name) const;

const AtomicString& getAttributeNS(const AtomicString& namespaceURI, const AtomicString& localName) const;

« no previous file with comments | « PerformanceTests/Bindings/set-attribute-rare.html ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »