Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: Source/core/dom/Element.h

Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add performance tests about rare attribute. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « PerformanceTests/Bindings/set-attribute-rare.html ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2013 Appl e Inc. All rights reserved. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2013 Appl e Inc. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
125 bool hasNamedNodeMap() const; 125 bool hasNamedNodeMap() const;
126 #endif 126 #endif
127 bool hasAttributes() const; 127 bool hasAttributes() const;
128 // This variant will not update the potentially invalid attributes. To be us ed when not interested 128 // This variant will not update the potentially invalid attributes. To be us ed when not interested
129 // in style attribute or one of the SVG animation attributes. 129 // in style attribute or one of the SVG animation attributes.
130 bool hasAttributesWithoutUpdate() const; 130 bool hasAttributesWithoutUpdate() const;
131 131
132 bool hasAttribute(const AtomicString& name) const; 132 bool hasAttribute(const AtomicString& name) const;
133 bool hasAttributeNS(const AtomicString& namespaceURI, const AtomicString& lo calName) const; 133 bool hasAttributeNS(const AtomicString& namespaceURI, const AtomicString& lo calName) const;
134 134
135 const AtomicString& bindingsGetAttribute(const String& name) const;
136 void bindingsSetAttribute(const String& name, const AtomicString& value, Exc eptionState&);
137
135 const AtomicString& getAttribute(const AtomicString& name) const; 138 const AtomicString& getAttribute(const AtomicString& name) const;
136 const AtomicString& getAttributeNS(const AtomicString& namespaceURI, const A tomicString& localName) const; 139 const AtomicString& getAttributeNS(const AtomicString& namespaceURI, const A tomicString& localName) const;
137 140
138 void setAttribute(const AtomicString& name, const AtomicString& value, Excep tionState&); 141 void setAttribute(const AtomicString& name, const AtomicString& value, Excep tionState&);
139 static bool parseAttributeName(QualifiedName&, const AtomicString& namespace URI, const AtomicString& qualifiedName, ExceptionState&); 142 static bool parseAttributeName(QualifiedName&, const AtomicString& namespace URI, const AtomicString& qualifiedName, ExceptionState&);
140 void setAttributeNS(const AtomicString& namespaceURI, const AtomicString& qu alifiedName, const AtomicString& value, ExceptionState&); 143 void setAttributeNS(const AtomicString& namespaceURI, const AtomicString& qu alifiedName, const AtomicString& value, ExceptionState&);
141 144
142 bool isIdAttributeName(const QualifiedName&) const; 145 bool isIdAttributeName(const QualifiedName&) const;
143 const AtomicString& getIdAttribute() const; 146 const AtomicString& getIdAttribute() const;
144 void setIdAttribute(const AtomicString&); 147 void setIdAttribute(const AtomicString&);
(...skipping 749 matching lines...) Expand 10 before | Expand all | Expand 10 after
894 template <> inline bool isElementOfType<const thisType>(const Element& eleme nt) { return element.predicate; } \ 897 template <> inline bool isElementOfType<const thisType>(const Element& eleme nt) { return element.predicate; } \
895 DEFINE_NODE_TYPE_CASTS(thisType, predicate) 898 DEFINE_NODE_TYPE_CASTS(thisType, predicate)
896 899
897 #define DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) \ 900 #define DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType) \
898 template <> inline bool isElementOfType<const thisType>(const Element& eleme nt) { return is##thisType(element); } \ 901 template <> inline bool isElementOfType<const thisType>(const Element& eleme nt) { return is##thisType(element); } \
899 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(thisType) 902 DEFINE_NODE_TYPE_CASTS_WITH_FUNCTION(thisType)
900 903
901 } // namespace 904 } // namespace
902 905
903 #endif 906 #endif
OLDNEW
« no previous file with comments | « PerformanceTests/Bindings/set-attribute-rare.html ('k') | Source/core/dom/Element.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698