PerformanceTests/Bindings/set-attribute-rare.html - Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PerformanceTests/Bindings/set-attribute-rare.html

Issue 189483004: WontFix: Add fast path for id/name/style/class in getAttribute/setAttribute bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add performance tests about rare attribute. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: PerformanceTests/Bindings/set-attribute-rare.html

diff --git a/PerformanceTests/Bindings/set-attribute.html b/PerformanceTests/Bindings/set-attribute-rare.html

similarity index 82%

copy from PerformanceTests/Bindings/set-attribute.html

copy to PerformanceTests/Bindings/set-attribute-rare.html

index dbc72a328f67c6e5c72c5b049bdb7215efdac6f5..96e5ebdb45ecac3fa04ad00c161176cf13f35de7 100644

--- a/PerformanceTests/Bindings/set-attribute.html

+++ b/PerformanceTests/Bindings/set-attribute-rare.html

@@ -1,7 +1,7 @@

<!DOCTYPE html>

<html>

<body>

-<div id="foo"></div>

+<div id="foo" role="group"></div>

var div = document.getElementById("foo");

@@ -11,7 +11,7 @@ PerfTestRunner.measureRunsPerSecond({

run: function() {

var localDiv = div;

for (var i = 0; i < 10000; i++)

- localDiv.setAttribute("id", "foo");

+ localDiv.setAttribute("role", "group");

}});

</script>

</body>

« no previous file with comments | « PerformanceTests/Bindings/get-attribute-rare.html ('k') | Source/core/dom/Element.h » ('j') | no next file with comments »