Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1894563002: [WebView] Disallow geolocation on insecure origins for apps targeting N and higher. (Closed)

Created:
4 years, 8 months ago by timvolodine
Modified:
4 years, 8 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[WebView] Disallow geolocation on insecure origins for apps targeting N and higher. Merge to M51. In Chrome geolocation has been disabled on insecure origins previously in crrev.com/1485973002. For WebView we are enabling same behavior for apps that are targeting N and higher versions of Android. This is to allow for a smooth transition and remain reasonably backwards compatible with older apps. BUG=603574 TBR=torne@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1882783002 Cr-Commit-Position: refs/heads/master@{#387299} (cherry picked from commit 4f4086735aeb59b937e8216c923f0ea7c58a3602)

Patch Set 1 #

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894563002/1
4 years, 8 months ago (2016-04-15 15:45:46 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 8 months ago (2016-04-15 15:45:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894563002/1
4 years, 8 months ago (2016-04-15 15:47:53 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 15:49:27 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698