Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: android_webview/native/aw_settings.cc

Issue 1894563002: [WebView] Disallow geolocation on insecure origins for apps targeting N and higher. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "android_webview/native/aw_settings.h" 5 #include "android_webview/native/aw_settings.h"
6 6
7 #include "android_webview/browser/aw_content_browser_client.h" 7 #include "android_webview/browser/aw_content_browser_client.h"
8 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h" 8 #include "android_webview/browser/renderer_host/aw_render_view_host_ext.h"
9 #include "android_webview/common/aw_content_client.h" 9 #include "android_webview/common/aw_content_client.h"
10 #include "android_webview/native/aw_contents.h" 10 #include "android_webview/native/aw_contents.h"
(...skipping 421 matching lines...) Expand 10 before | Expand all | Expand 10 after
432 web_prefs->allow_running_insecure_content = 432 web_prefs->allow_running_insecure_content =
433 Java_AwSettings_getAllowRunningInsecureContentLocked(env, obj); 433 Java_AwSettings_getAllowRunningInsecureContentLocked(env, obj);
434 434
435 web_prefs->fullscreen_supported = 435 web_prefs->fullscreen_supported =
436 Java_AwSettings_getFullscreenSupportedLocked(env, obj); 436 Java_AwSettings_getFullscreenSupportedLocked(env, obj);
437 web_prefs->record_whole_document = 437 web_prefs->record_whole_document =
438 Java_AwSettings_getRecordFullDocument(env, obj); 438 Java_AwSettings_getRecordFullDocument(env, obj);
439 439
440 // TODO(jww): This should be removed once sufficient warning has been given of 440 // TODO(jww): This should be removed once sufficient warning has been given of
441 // possible API breakage because of disabling insecure use of geolocation. 441 // possible API breakage because of disabling insecure use of geolocation.
442 web_prefs->allow_geolocation_on_insecure_origins = true; 442 web_prefs->allow_geolocation_on_insecure_origins =
443 Java_AwSettings_getAllowGeolocationOnInsecureOrigins(env, obj);
443 } 444 }
444 445
445 static jlong Init(JNIEnv* env, 446 static jlong Init(JNIEnv* env,
446 const JavaParamRef<jobject>& obj, 447 const JavaParamRef<jobject>& obj,
447 const JavaParamRef<jobject>& web_contents) { 448 const JavaParamRef<jobject>& web_contents) {
448 content::WebContents* contents = content::WebContents::FromJavaWebContents( 449 content::WebContents* contents = content::WebContents::FromJavaWebContents(
449 web_contents); 450 web_contents);
450 AwSettings* settings = new AwSettings(env, obj, contents); 451 AwSettings* settings = new AwSettings(env, obj, contents);
451 return reinterpret_cast<intptr_t>(settings); 452 return reinterpret_cast<intptr_t>(settings);
452 } 453 }
453 454
454 static ScopedJavaLocalRef<jstring> GetDefaultUserAgent( 455 static ScopedJavaLocalRef<jstring> GetDefaultUserAgent(
455 JNIEnv* env, 456 JNIEnv* env,
456 const JavaParamRef<jclass>& clazz) { 457 const JavaParamRef<jclass>& clazz) {
457 return base::android::ConvertUTF8ToJavaString(env, GetUserAgent()); 458 return base::android::ConvertUTF8ToJavaString(env, GetUserAgent());
458 } 459 }
459 460
460 bool RegisterAwSettings(JNIEnv* env) { 461 bool RegisterAwSettings(JNIEnv* env) {
461 return RegisterNativesImpl(env); 462 return RegisterNativesImpl(env);
462 } 463 }
463 464
464 } // namespace android_webview 465 } // namespace android_webview
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698