[WebView] Disallow geolocation on insecure origins for apps targeting N and higher.

[WebView] Disallow geolocation on insecure origins for apps targeting N and higher.

In Chrome geolocation has been disabled on insecure origins
previously in crrev.com/1485973002.

For WebView we are enabling same behavior for apps that are
targeting N and higher versions of Android. This is to allow
for a smooth transition and remain reasonably backwards
compatible with older apps.

BUG=520765
Committed: https://crrev.com/4f4086735aeb59b937e8216c923f0ea7c58a3602
Cr-Commit-Position: refs/heads/master@{#387299}

[timvolodine, 2016-04-13 11:08:03]

Description was changed from

==========
[WebView] Disallow geolocation on insecure origins for apps targeting N and
higher.

In Chrome geolocation has been disabled on insecure origins
previously in crrev.com/1485973002.

For WebView we are enabling same behavior for apps that are
targeting N+ versions of Android. This is to allow for a
smooth transition and remain reasonably backwards compatible
with older apps.

BUG=520765
==========

to

==========
[WebView] Disallow geolocation on insecure origins for apps targeting N and
higher.

In Chrome geolocation has been disabled on insecure origins
previously in crrev.com/1485973002.

For WebView we are enabling same behavior for apps that are
targeting N and higher versions of Android. This is to allow
for a smooth transition and remain reasonably backwards
compatible with older apps.

BUG=520765
==========

[timvolodine, 2016-04-13 11:36:37]

timvolodine@chromium.org changed reviewers:
+ torne@chromium.org

[Torne, 2016-04-13 15:33:02]

https://codereview.chromium.org/1882783002/diff/1/android_webview/java/src/or...
File android_webview/java/src/org/chromium/android_webview/AwSettings.java
(right):

https://codereview.chromium.org/1882783002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:115:
private boolean mAllowGeolocationOnInsecureOrigins = true;
The other API level settings are final; I assume they just set it in
construction in the relevant tests? Is it a problem to make this work the same
way?

[timvolodine, 2016-04-13 16:38:57]

https://codereview.chromium.org/1882783002/diff/1/android_webview/java/src/or...
File android_webview/java/src/org/chromium/android_webview/AwSettings.java
(right):

https://codereview.chromium.org/1882783002/diff/1/android_webview/java/src/or...
android_webview/java/src/org/chromium/android_webview/AwSettings.java:115:
private boolean mAllowGeolocationOnInsecureOrigins = true;
On 2016/04/13 15:33:01, Torne wrote:
> The other API level settings are final; I assume they just set it in
> construction in the relevant tests? Is it a problem to make this work the same
> way?

right, not a problem ;) done.

[Torne, 2016-04-13 16:42:13]

lgtm

[sgurun-gerrit only, 2016-04-13 22:24:49]

On 2016/04/13 16:42:13, Torne wrote:
> lgtm

jww, FYI

[timvolodine, 2016-04-14 12:59:55]

The CQ bit was checked by timvolodine@chromium.org

[commit-bot: I haz the power, 2016-04-14 13:00:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1882783002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1882783002/20001

[commit-bot: I haz the power, 2016-04-14 13:38:37]

Description was changed from

==========
[WebView] Disallow geolocation on insecure origins for apps targeting N and
higher.

In Chrome geolocation has been disabled on insecure origins
previously in crrev.com/1485973002.

For WebView we are enabling same behavior for apps that are
targeting N and higher versions of Android. This is to allow
for a smooth transition and remain reasonably backwards
compatible with older apps.

BUG=520765
==========

to

==========
[WebView] Disallow geolocation on insecure origins for apps targeting N and
higher.

In Chrome geolocation has been disabled on insecure origins
previously in crrev.com/1485973002.

For WebView we are enabling same behavior for apps that are
targeting N and higher versions of Android. This is to allow
for a smooth transition and remain reasonably backwards
compatible with older apps.

BUG=520765
==========

[commit-bot: I haz the power, 2016-04-14 13:38:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-14 13:40:18]

Description was changed from

==========
[WebView] Disallow geolocation on insecure origins for apps targeting N and
higher.

In Chrome geolocation has been disabled on insecure origins
previously in crrev.com/1485973002.

For WebView we are enabling same behavior for apps that are
targeting N and higher versions of Android. This is to allow
for a smooth transition and remain reasonably backwards
compatible with older apps.

BUG=520765
==========

to

==========
[WebView] Disallow geolocation on insecure origins for apps targeting N and
higher.

In Chrome geolocation has been disabled on insecure origins
previously in crrev.com/1485973002.

For WebView we are enabling same behavior for apps that are
targeting N and higher versions of Android. This is to allow
for a smooth transition and remain reasonably backwards
compatible with older apps.

BUG=520765

Committed: https://crrev.com/4f4086735aeb59b937e8216c923f0ea7c58a3602
Cr-Commit-Position: refs/heads/master@{#387299}
==========

[commit-bot: I haz the power, 2016-04-14 13:40:19]

Patchset 2 (id:??) landed as
https://crrev.com/4f4086735aeb59b937e8216c923f0ea7c58a3602
Cr-Commit-Position: refs/heads/master@{#387299}